Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyflyte-exec-alternative as the entrypoint for SageMaker Custom Training Job #163

Closed
wants to merge 18 commits into from

Conversation

bnsblue
Copy link
Contributor

@bnsblue bnsblue commented Aug 21, 2020

TL;DR

This PR adds an alternative pyflyte entrypoint for SageMaker Custom Training Job.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This PR adds an alternative entry point pyflyte-execute-alternative for SageMaker Custom Training Job.
This entry point will be invoked as a subprocess by the runner script. The runner script will pass the hyperparameters as command-line arguments. Therefore, the key component in the implementation of this alternative entry point is the conversion from string-typed arguments to a proper LiteralMap.

Tracking Issue

flyteorg/flyte#479

Follow-up issue

NA

@bnsblue bnsblue marked this pull request as draft August 21, 2020 06:14
@kumare3
Copy link
Contributor

kumare3 commented Aug 21, 2020

Let's keep the name short- pyflyte-exec-alt?

@kumare3 kumare3 closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants