-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyflyte-exec-alternative as the entrypoint for SageMaker Custom Training Job #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnsblue
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
August 21, 2020 06:13
Let's keep the name short- pyflyte-exec-alt? |
…/flytekit into bnsblue/sm-pyflyte-exec-alternative
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds an alternative pyflyte entrypoint for SageMaker Custom Training Job.
Type
Are all requirements met?
Complete description
This PR adds an alternative entry point
pyflyte-execute-alternative
for SageMaker Custom Training Job.This entry point will be invoked as a subprocess by the runner script. The runner script will pass the hyperparameters as command-line arguments. Therefore, the key component in the implementation of this alternative entry point is the conversion from string-typed arguments to a proper LiteralMap.
Tracking Issue
flyteorg/flyte#479
Follow-up issue
NA