Beautify deviceflow prompt #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronHsu
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 71.04% 71.01% -0.03%
==========================================
Files 335 336 +1
Lines 30661 30726 +65
Branches 5558 5567 +9
==========================================
+ Hits 21783 21821 +38
- Misses 8336 8361 +25
- Partials 542 544 +2
|
kumare3
reviewed
May 9, 2023
| OR copy paste the following URL: {resp.verification_uri_complete} | ||
| """ | ||
| ) | ||
| text = f"To Authenticate, navigate in a browser to the following URL: {click.style(resp.verification_uri, fg='blue', underline=True)} and enter code: {click.style(resp.user_code, fg='blue')}" |
There was a problem hiding this comment.
Actually let's use rich console
There was a problem hiding this comment.
Do you mean using the logger? Looks kinda weird
There was a problem hiding this comment.
ya not the logger, i meant rich.console. but let it be what it was, can you revert and i can approve!
ByronHsu
force-pushed
the
beautify-deviceflow
branch
from
7663a38 to
095f2f5
Compare
|
Some build fails? |
pingsutw
previously approved these changes
May 12, 2023
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
ByronHsu
force-pushed
the
beautify-deviceflow
branch
from
44429ae to
d8a7440
Compare
Signed-off-by: byhsu <[email protected]>
pingsutw
approved these changes
May 19, 2023
eapolinario
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Beautify deviceflow prompt Signed-off-by: byhsu <[email protected]> * lint! Signed-off-by: byhsu <[email protected]> * lint Signed-off-by: byhsu <[email protected]> --------- Signed-off-by: byhsu <[email protected]> Co-authored-by: byhsu <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Jul 12, 2023
* Multi arch imageSpec (#1630) Multi arch imageSpec (#1630) Signed-off-by: Eduardo Apolinario <[email protected]> * Add executor_path and applications_path to spark config (#1634) * Add executor_path and applications_path to spark config Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> * Add support for env vars to pyflyte run (#1617) * Add support for env vars to pyflyte run Signed-off-by: Kevin Su <[email protected]> * bump idl Signed-off-by: Kevin Su <[email protected]> * update doc Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Fetch task executions in dynamic (#1636) * fetch task executions in dynamic Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> * Added metrics command to pyflyte (#1513) Signed-off-by: Daniel Rammer <[email protected]> * Add http_proxy to client & Fix deviceflow (#1611) * Add http_proxy to client & Fix deviceflow RB=3890720 Signed-off-by: byhsu <[email protected]> * nit Signed-off-by: byhsu <[email protected]> * lint! Signed-off-by: byhsu <[email protected]> --------- Signed-off-by: byhsu <[email protected]> Co-authored-by: byhsu <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Improve variable names (#1642) Signed-off-by: byhsu <[email protected]> Co-authored-by: byhsu <[email protected]> * Address resolution (#1567) Signed-off-by: Yee Hing Tong <[email protected]> * pyflyte run supports pickle (#1646) Signed-off-by: Kevin Su <[email protected]> * Wait for the pod plugin instead of flytekit (#1647) Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> * Beautify deviceflow prompt (#1625) * Beautify deviceflow prompt Signed-off-by: byhsu <[email protected]> * lint! Signed-off-by: byhsu <[email protected]> * lint Signed-off-by: byhsu <[email protected]> --------- Signed-off-by: byhsu <[email protected]> Co-authored-by: byhsu <[email protected]> * Improve flytekit register (#1643) * Fix pyflyte register Signed-off-by: byhsu <[email protected]> * revert Signed-off-by: byhsu <[email protected]> * lint Signed-off-by: byhsu <[email protected]> --------- Signed-off-by: byhsu <[email protected]> Co-authored-by: byhsu <[email protected]> * Pass verify flag to all authenticators (#1641) Signed-off-by: byhsu <[email protected]> * Allow annotated FlyteFile as task input argument (#1632) * fix: Allow annotated FlyteFile as task input argument Using an annotated FlyteFile type as an input to a task was previously impossible due to an exception being raised in `FlyteFilePathTransformer.to_python_value`. This commit applies the fix previously used in `FlyteFilePathTransformer.to_literal` to permit using annotated FlyteFiles as either inputs and outputs of a task. Issue: #3424 Signed-off-by: Adrian Rumpold <[email protected]> * refactor: Unified handling of annotated types in type engine Issue: #3424 Signed-off-by: Adrian Rumpold <[email protected]> * fix: Use py3.8-compatible types in type engine tests Issue: #3424 Signed-off-by: Adrian Rumpold <[email protected]> --------- Signed-off-by: Adrian Rumpold <[email protected]> * Use logger instead of print statement in sqlalchemy plugin (#1651) * use logging info instead of print Signed-off-by: wirthual <[email protected]> * isorted files Signed-off-by: wirthual <[email protected]> * import root logger from flytekit Signed-off-by: wirthual <[email protected]> --------- Signed-off-by: wirthual <[email protected]> * Map over notebook task (#1650) * map over notebook Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * tests Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * add a flag Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * Fix tests Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> * Support single literals in tiny url (#1654) Signed-off-by: Yee Hing Tong <[email protected]> * Add support overriding image (#1652) Signed-off-by: Kevin Su <[email protected]> * Fix ability to pass None to task with Optional kwarg, add test (#1657) Signed-off-by: Fabio Grätz <[email protected]> Co-authored-by: Fabio Grätz <[email protected]> * Regenerate plugins requirements Signed-off-by: eduardo apolinario <[email protected]> * Regenerate plugins requirements and linting Signed-off-by: eduardo apolinario <[email protected]> * Regenerate whylogs requirements Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: byhsu <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Adrian Rumpold <[email protected]> Signed-off-by: wirthual <[email protected]> Signed-off-by: Fabio Grätz <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Co-authored-by: ByronHsu <[email protected]> Co-authored-by: byhsu <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> Co-authored-by: Adrian Rumpold <[email protected]> Co-authored-by: wirthual <[email protected]> Co-authored-by: Fabio M. Graetz, Ph.D <[email protected]> Co-authored-by: Fabio Grätz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Complete description
To make deviceflow prompt more prominent
Note: for why
verification_url_completedis removed, check #1611