Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify sqlalchemy Dockerfiles #1585

Merged
merged 3 commits into from
Apr 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pythonpublish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ jobs:
tags: ${{ steps.sqlalchemy-names.outputs.tags }}
build-args: |
VERSION=${{ needs.deploy.outputs.version }}
file: ./plugins/flytekit-sqlalchemy/Dockerfile.py${{ matrix.python-version }}
PYTHON_VERSION=${{ matrix.python-version }}
file: ./plugins/flytekit-sqlalchemy/Dockerfile
cache-from: type=gha
cache-to: type=gha,mode=max
19 changes: 19 additions & 0 deletions plugins/flytekit-sqlalchemy/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
ARG PYTHON_VERSION
FROM python:${PYTHON_VERSION}-slim-buster

WORKDIR /root
ENV LANG C.UTF-8
ENV LC_ALL C.UTF-8
ENV PYTHONPATH /root

ARG VERSION

RUN pip install sqlalchemy \
psycopg2-binary \
pymysql \
flytekitplugins-sqlalchemy==$VERSION \
flytekit==$VERSION

RUN useradd -u 1000 flytekit
RUN chown flytekit: /root
USER flytekit
25 changes: 0 additions & 25 deletions plugins/flytekit-sqlalchemy/Dockerfile.py3.10

This file was deleted.

25 changes: 0 additions & 25 deletions plugins/flytekit-sqlalchemy/Dockerfile.py3.7

This file was deleted.

25 changes: 0 additions & 25 deletions plugins/flytekit-sqlalchemy/Dockerfile.py3.8

This file was deleted.

25 changes: 0 additions & 25 deletions plugins/flytekit-sqlalchemy/Dockerfile.py3.9

This file was deleted.