Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow plugin implementation #141

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jul 22, 2020

TL;DR

Tensorflow plugin for Flyte that leverages https://github.com/kubeflow/tf-operator to run distributed tensorflow jobs on k8s.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tensorflow plugin for Flyte that leverages https://github.com/kubeflow/tf-operator to run distributed TensorFlow jobs on k8s.
https://pypi.org/project/flyteidl/0.17.36/
Related PRs:
TFOperator support in FlytePlugins
flyteorg/flyte#115

Subtask:
flyteorg/flyteidl#71
flyteorg/flyteplugins#103
flyteorg/flyte#424

Tracking Issue

NA

Follow-up issue

NA

@kumare3
Copy link
Contributor

kumare3 commented Jul 23, 2020

@pingsutw can I look at it tomorrow morning?

@pingsutw
Copy link
Member Author

@kumare3 Sure, I'm not in a hurry.

@kumare3
Copy link
Contributor

kumare3 commented Jul 23, 2020

the PR is failing because of some un-related error. I see that happening for all PR's

@kumare3
Copy link
Contributor

kumare3 commented Jul 23, 2020

This actually looks pretty good to me. We should probably add an example in flytesnacks.

@kumare3
Copy link
Contributor

kumare3 commented Jul 23, 2020

@wild-endeavor do you have any comments?

@pingsutw
Copy link
Member Author

@kumare3 Thanks for the review.
After PR is merged, I will add an example in flytesnacks.

@wild-endeavor
Copy link
Contributor

@pingsutw I don't think I have access to your fork. Could you help us clean up the lint errors? If not, feel free to change this to a PR to go in something other than the master branch, and I can pull it and modify it.

Thanks!

@wild-endeavor wild-endeavor changed the base branch from master to pingsutwping-1 September 14, 2020 20:38
@wild-endeavor wild-endeavor merged commit bfa2040 into flyteorg:pingsutwping-1 Sep 14, 2020
@wild-endeavor
Copy link
Contributor

wild-endeavor commented Sep 14, 2020

Hey I want to make a few more changes to this PR, so merged it into a different branch, but on the main fork. I'll open up a new PR into master and tag you on it. Thanks @pingsutw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants