Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins requirements files versions #1365

Merged
merged 20 commits into from
Dec 13, 2022

Conversation

eapolinario
Copy link
Collaborator

@eapolinario eapolinario commented Dec 9, 2022

Signed-off-by: Eduardo Apolinario [email protected]

TL;DR

Ensure all plugins tests can run with flytekit 1.3.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Not all plugins can run with the latest version of flyetkit, the one exception being the flytekit-onnx-tensorflow plugin, so we're furloughing it until tensorflow can work with protobuf>4.

Users who see an error related to protobufs in plugins will need to set the environment variable PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python as suggested by protobuf.

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #1365 (00d2b62) into master (c3d54b1) will decrease coverage by 1.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
- Coverage   70.42%   69.09%   -1.33%     
==========================================
  Files         295      295              
  Lines       25917    26984    +1067     
  Branches     2156     2538     +382     
==========================================
+ Hits        18251    18644     +393     
- Misses       7154     7843     +689     
+ Partials      512      497      -15     
Impacted Files Coverage Δ
tests/flytekit/unit/core/tracker/d.py 40.00% <0.00%> (-10.00%) ⬇️
flytekit/models/execution.py 42.20% <0.00%> (-9.43%) ⬇️
flytekit/models/core/workflow.py 42.63% <0.00%> (-9.26%) ⬇️
flytekit/models/core/identifier.py 38.70% <0.00%> (-8.66%) ⬇️
flytekit/models/dynamic_job.py 37.50% <0.00%> (-8.66%) ⬇️
flytekit/models/project.py 34.28% <0.00%> (-8.58%) ⬇️
flytekit/models/literals.py 40.28% <0.00%> (-8.32%) ⬇️
flytekit/models/core/compiler.py 32.00% <0.00%> (-7.35%) ⬇️
flytekit/models/schedule.py 32.39% <0.00%> (-7.27%) ⬇️
flytekit/models/core/condition.py 34.56% <0.00%> (-7.23%) ⬇️
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
…tekit from repo in all plugins

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit 39ab92b.

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
…up to furloughed_setup.py

Signed-off-by: Eduardo Apolinario <[email protected]>
wild-endeavor
wild-endeavor previously approved these changes Dec 13, 2022
@eapolinario eapolinario reopened this Dec 13, 2022
@eapolinario eapolinario merged commit 8181742 into master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants