-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile the workflow only at compile time #1311
Merged
Merged
Changes from 7 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b059259
wip
pingsutw e8a123f
wip
pingsutw 51f9604
wip
pingsutw 640a6ff
wip
pingsutw 2e13d5c
wip
pingsutw 03f61cb
add tests
pingsutw 2594a50
add tests
pingsutw ae6757f
Merge branch 'master' of github.com:flyteorg/flytekit into fix-compile
pingsutw d16c100
support dynamic task
pingsutw 828da98
test
pingsutw 9d3b0e4
test
pingsutw 0474c17
nit
pingsutw 2bf2947
lazy compile
pingsutw c44fab0
lint
pingsutw 87c189f
add tests
pingsutw 71c8fac
nit
pingsutw 5ca2e4a
nit
pingsutw 46fc70d
test
pingsutw e99b7ac
test
pingsutw 076bf16
lint
pingsutw 7b5b05e
test
pingsutw fd60562
test
pingsutw 81c8664
test
pingsutw 08c2d87
test
pingsutw f2bb161
nit
pingsutw 1a09a95
nit
pingsutw 8b72860
nit
pingsutw 37f23f9
update test
pingsutw 1affe90
Merge branch 'master' into fix-compile
pingsutw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @kumare3 could we just skip compile in
TASK_EXECUTION
mode (running the workflow on flyte cluster)?