Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logging to pyflyte launch plan activation command #117

Merged
merged 2 commits into from
May 30, 2020

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented May 30, 2020

TL;DR

I want just a bit more information to be logged in this command.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Adding code to the main pyflyte command to respect the internal logging configuration option. If set, it will be used.
  • Added a couple log lines.

Tracking Issue

NA

Follow-up issue

NA

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020

Codecov Report

Merging #117 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   81.84%   81.83%   -0.02%     
==========================================
  Files         211      211              
  Lines       13654    13661       +7     
  Branches     1125     1126       +1     
==========================================
+ Hits        11175    11179       +4     
- Misses       2213     2215       +2     
- Partials      266      267       +1     
Impacted Files Coverage Δ
flytekit/clis/sdk_in_container/launch_plan.py 71.13% <33.33%> (-1.21%) ⬇️
flytekit/clis/sdk_in_container/pyflyte.py 78.68% <80.00%> (-0.26%) ⬇️
flytekit/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b5bf1...9787365. Read the comment docs.

@wild-endeavor wild-endeavor merged commit e65b1bb into master May 30, 2020
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants