Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docstrings for pod task #1153

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Adds docstrings for pod task #1153

merged 4 commits into from
Sep 15, 2022

Conversation

SmritiSatyanV
Copy link
Contributor

@SmritiSatyanV SmritiSatyanV commented Sep 9, 2022

Adds docstrings for pod task
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1153 (529b5d0) into master (46a6129) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 529b5d0 differs from pull request most recent head 61f0a7e. Consider uploading reports for the commit 61f0a7e to get more accurate results

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
+ Coverage   68.43%   68.51%   +0.07%     
==========================================
  Files         288      288              
  Lines       26032    26085      +53     
  Branches     2915     2918       +3     
==========================================
+ Hits        17816    17871      +55     
+ Misses       7736     7735       -1     
+ Partials      480      479       -1     
Impacted Files Coverage Δ
flytekit/tools/repo.py 73.68% <0.00%> (ø)
flytekit/tools/fast_registration.py 89.06% <0.00%> (ø)
...ests/flytekit/unit/tools/test_fast_registration.py 100.00% <0.00%> (ø)
tests/flytekit/unit/core/test_type_engine.py 98.39% <0.00%> (+<0.01%) ⬆️
flytekit/core/type_engine.py 59.34% <0.00%> (+0.09%) ⬆️
flytekit/clis/sdk_in_container/package.py 96.29% <0.00%> (+0.14%) ⬆️
tests/flytekit/unit/cli/pyflyte/test_run.py 99.20% <0.00%> (+0.32%) ⬆️
flytekit/clis/sdk_in_container/register.py 80.76% <0.00%> (+0.37%) ⬆️
flytekit/clis/sdk_in_container/run.py 84.19% <0.00%> (+0.59%) ⬆️
flytekit/clis/sdk_in_container/serialize.py 57.14% <0.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SmritiSatyanV SmritiSatyanV marked this pull request as ready for review September 9, 2022 11:39
fix lint errors
Signed-off-by: SmritiSatyanV [email protected]
Based on review
Signed-off-by: SmritiSatyanV [email protected]
Changes based on review
Signed-off-by: SmritiSatyanV <[email protected]>
@SmritiSatyanV SmritiSatyanV merged commit 51f34ba into master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Update docstrings for pod plugin
4 participants