Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor doc and code updates #1139

Merged
merged 2 commits into from
Aug 24, 2022
Merged

minor doc and code updates #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf29971
minor doc and code updates
samhita-alla Aug 23, 2022
806b6dd
revert outputs_as_nchw
samhita-alla Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/source/design/control_plane.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ Retrieving & Inspecting Executions
**********************************

After an execution is completed, you can retrieve the execution using the :meth:`~flytekit.remote.remote.FlyteRemote.fetch_execution` method.
The fetched execution can be used to retrieve the inputs and outputs of the execution.
The fetched execution can be used to retrieve the inputs and outputs of an execution.

.. code-block:: python
Expand Down Expand Up @@ -307,6 +307,8 @@ To fetch output of a specific node execution:
node_execution_output = synced_execution.node_executions["n1"].outputs["model_file"]
:ref:`Node <flyte:divedeep-nodes>` here, can correspond to a task, workflow, or branch node.

****************
Listing Entities
****************
Expand Down
2 changes: 1 addition & 1 deletion docs/source/design/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ Flytekit is comprised of a handful of different logical components, each discuss

models
authoring
Control Plane <control_plane>
Control Plane: FlyteRemote <control_plane>
execution
clis
2 changes: 1 addition & 1 deletion plugins/flytekit-onnx-scikitlearn/flytekitplugins/onnxscikitlearn/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class ScikitLearn2ONNXConfig:
custom_parsers: Dict[Callable[..., Any], Callable[..., None]] = field(default_factory=dict)
options: Dict[Any, Any] = field(default_factory=dict)
intermediate: bool = False
naming: Union[str, Callable[..., Any]] = None
naming: Optional[Union[str, Callable[..., Any]]] = None
white_op: Optional[Set[str]] = None
black_op: Optional[Set[str]] = None
verbose: int = 0
Expand Down