Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove py.typed #1122

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Remove py.typed #1122

merged 2 commits into from
Aug 4, 2022

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Aug 4, 2022

TL;DR

It seems there is was a py.typed file that was inadvertently added as part of #1088. This is causing issues.

There are lots of places where we need to clean up mypy before adding this file.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Remove file.

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor marked this pull request as ready for review August 4, 2022 15:58
pingsutw
pingsutw previously approved these changes Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1122 (b9c06b7) into master (9b3aa0e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
+ Coverage   68.23%   68.26%   +0.02%     
==========================================
  Files         287      287              
  Lines       25786    25772      -14     
  Branches     2882     2525     -357     
==========================================
- Hits        17595    17592       -3     
+ Misses       7713     7704       -9     
+ Partials      478      476       -2     
Impacted Files Coverage Δ
flytekit/core/promise.py 51.22% <0.00%> (-0.57%) ⬇️
flytekit/clis/flyte_cli/main.py 44.34% <0.00%> (ø)
flytekit/extras/persistence/http.py 24.48% <0.00%> (ø)
flytekit/types/schema/types.py 37.70% <0.00%> (+0.15%) ⬆️
flytekit/models/security.py 13.15% <0.00%> (+0.33%) ⬆️
flytekit/types/file/file.py 60.13% <0.00%> (+0.41%) ⬆️
flytekit/types/directory/types.py 55.46% <0.00%> (+0.46%) ⬆️
flytekit/configuration/internal.py 17.91% <0.00%> (+1.91%) ⬆️
flytekit/interfaces/random.py 25.00% <0.00%> (+5.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wild-endeavor wild-endeavor merged commit 96c0b3c into master Aug 4, 2022
wild-endeavor added a commit that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants