Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sagemaker script back in #1112

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Jul 28, 2022

Signed-off-by: Ketan Umare [email protected]

TL;DR

Sagemaker script was erroneously removed by a previous commit, when scripts were migrated to individual plugins.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Ketan Umare <[email protected]>
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1112 (7628b50) into master (c011ef7) will decrease coverage by 18.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1112       +/-   ##
===========================================
- Coverage   86.29%   68.12%   -18.17%     
===========================================
  Files         255      287       +32     
  Lines       24284    25738     +1454     
  Branches     2768     2877      +109     
===========================================
- Hits        20955    17534     -3421     
- Misses       2856     7726     +4870     
- Partials      473      478        +5     
Impacted Files Coverage Δ
flytekit/deck/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/core/constants.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/core/resources.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/core/tracked_abc.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/types/file/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/types/pickle/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/types/schema/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/types/directory/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/core/dynamic_workflow_task.py 0.00% <0.00%> (-100.00%) ⬇️
flytekit/configuration/feature_flags.py 0.00% <0.00%> (-100.00%) ⬇️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c011ef7...7628b50. Read the comment docs.

Signed-off-by: Ketan Umare <[email protected]>
@wild-endeavor
Copy link
Contributor

wild-endeavor commented Jul 28, 2022

we'll need to port these changes to 1.1.x as well i can do that.

@samhita-alla samhita-alla merged commit ac01a73 into master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants