Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tar permisison override #1103

Merged

Conversation

bimtauer
Copy link
Contributor

TL;DR

This fixes an issue where unpacked fast-registered tar archives end up having d--------- as file permissions. Root doesn't care but we prefer not to run as root. With that line removed, the permissions end up drwx------ which works. uid and gid are overridden when unpacking so that part is no problem.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1103 (183b503) into master (d4b3c44) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
- Coverage   86.92%   86.92%   -0.01%     
==========================================
  Files         275      275              
  Lines       25453    25452       -1     
  Branches     2862     2862              
==========================================
- Hits        22125    22124       -1     
  Misses       2850     2850              
  Partials      478      478              
Impacted Files Coverage Δ
flytekit/tools/script_mode.py 73.52% <ø> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b3c44...183b503. Read the comment docs.

@bimtauer bimtauer force-pushed the fix/tar-permissions-when-not-root branch from dcf6e2d to 183b503 Compare July 14, 2022 16:09
@wild-endeavor wild-endeavor merged commit 795fd77 into flyteorg:master Jul 14, 2022
wild-endeavor pushed a commit that referenced this pull request Aug 2, 2022
wild-endeavor pushed a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants