minor doc and code updates (#1139)

* minor doc and code updates Signed-off-by: Samhita Alla <[email protected]> * revert outputs_as_nchw Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Samhita Alla <[email protected]>
flyteorg · Aug 24, 2022 · c4ba45a · c4ba45a
1 parent 6f19d74
commit c4ba45a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/docs/source/design/control_plane.rst b/docs/source/design/control_plane.rst
@@ -271,7 +271,7 @@ Retrieving & Inspecting Executions
 **********************************
 
 After an execution is completed, you can retrieve the execution using the :meth:`~flytekit.remote.remote.FlyteRemote.fetch_execution` method.
-The fetched execution can be used to retrieve the inputs and outputs of the execution.
+The fetched execution can be used to retrieve the inputs and outputs of an execution.
 
 .. code-block:: python
 
@@ -307,6 +307,8 @@ To fetch output of a specific node execution:
 
     node_execution_output = synced_execution.node_executions["n1"].outputs["model_file"]
 
+:ref:`Node <flyte:divedeep-nodes>` here, can correspond to a task, workflow, or branch node.
+
 ****************
 Listing Entities
 ****************

diff --git a/docs/source/design/index.rst b/docs/source/design/index.rst
@@ -19,6 +19,6 @@ Flytekit is comprised of a handful of different logical components, each discuss
 
    models
    authoring
-   Control Plane <control_plane>
+   Control Plane: FlyteRemote <control_plane>
    execution
    clis
diff --git a/plugins/flytekit-onnx-scikitlearn/flytekitplugins/onnxscikitlearn/schema.py b/plugins/flytekit-onnx-scikitlearn/flytekitplugins/onnxscikitlearn/schema.py
@@ -30,7 +30,7 @@ class ScikitLearn2ONNXConfig:
     custom_parsers: Dict[Callable[..., Any], Callable[..., None]] = field(default_factory=dict)
     options: Dict[Any, Any] = field(default_factory=dict)
     intermediate: bool = False
-    naming: Union[str, Callable[..., Any]] = None
+    naming: Optional[Union[str, Callable[..., Any]]] = None
     white_op: Optional[Set[str]] = None
     black_op: Optional[Set[str]] = None
     verbose: int = 0