Prevent mutable default arguments (#2443)

* Prevent mutable default arguments Signed-off-by: Eduardo Apolinario <[email protected]> * Do not lint tests Signed-off-by: Eduardo Apolinario <[email protected]> * Bump precommit hook version Signed-off-by: Eduardo Apolinario <[email protected]> * Remove default value for dictionary in Spark class Signed-off-by: Eduardo Apolinario <[email protected]> * Run precommit hook locally Signed-off-by: Eduardo Apolinario <[email protected]> * Fix lint error in openai plugin Signed-off-by: Eduardo Apolinario <[email protected]> * Handle nil databricks_conf in spark plugin Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
flyteorg · Jun 6, 2024 · c03eaad · c03eaad
1 parent 72af7c6
commit c03eaad
Show file tree

Hide file tree

Showing 45 changed files with 77 additions and 84 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,7 +1,7 @@
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
     # Ruff version.
-    rev: v0.2.2
+    rev: v0.4.7
     hooks:
       # Run the linter.
       - id: ruff

diff --git a/flytekit/__init__.py b/flytekit/__init__.py
@@ -202,6 +202,7 @@
    SourceCode
 
 """
+
 import os
 import sys
 from typing import Generator

diff --git a/flytekit/clients/auth/authenticator.py b/flytekit/clients/auth/authenticator.py
@@ -35,8 +35,7 @@ class ClientConfigStore(object):
     """
 
     @abstractmethod
-    def get_client_config(self) -> ClientConfig:
-        ...
+    def get_client_config(self) -> ClientConfig: ...
 
 
 class StaticClientConfigStore(ClientConfigStore):
@@ -81,8 +80,7 @@ def fetch_grpc_call_auth_metadata(self) -> typing.Optional[typing.Tuple[str, str
         return None
 
     @abstractmethod
-    def refresh_credentials(self):
-        ...
+    def refresh_credentials(self): ...
 
 
 class PKCEAuthenticator(Authenticator):

diff --git a/flytekit/configuration/__init__.py b/flytekit/configuration/__init__.py
@@ -126,6 +126,7 @@
    ~DataConfig
 
 """
+
 from __future__ import annotations
 
 import base64

diff --git a/flytekit/configuration/plugin.py b/flytekit/configuration/plugin.py
@@ -17,6 +17,7 @@
 my_plugin = "my_module:MyCustomPlugin"
 ```
 """
+
 from typing import Optional, Protocol, runtime_checkable
 
 from click import Group

diff --git a/flytekit/core/artifact.py b/flytekit/core/artifact.py
@@ -607,14 +607,11 @@ class ArtifactSerializationHandler(typing.Protocol):
     This protocol defines the interface for serializing artifact-related entities down to Flyte IDL.
     """
 
-    def partitions_to_idl(self, p: Optional[Partitions], **kwargs) -> Optional[art_id.Partitions]:
-        ...
+    def partitions_to_idl(self, p: Optional[Partitions], **kwargs) -> Optional[art_id.Partitions]: ...
 
-    def time_partition_to_idl(self, tp: Optional[TimePartition], **kwargs) -> Optional[art_id.TimePartition]:
-        ...
+    def time_partition_to_idl(self, tp: Optional[TimePartition], **kwargs) -> Optional[art_id.TimePartition]: ...
 
-    def artifact_query_to_idl(self, aq: ArtifactQuery, **kwargs) -> art_id.ArtifactQuery:
-        ...
+    def artifact_query_to_idl(self, aq: ArtifactQuery, **kwargs) -> art_id.ArtifactQuery: ...
 
 
 class DefaultArtifactSerializationHandler(ArtifactSerializationHandler):

diff --git a/flytekit/core/context_manager.py b/flytekit/core/context_manager.py
@@ -560,8 +560,7 @@ class SerializableToString(typing.Protocol):
     and then added to a literal's metadata.
     """
 
-    def serialize_to_string(self, ctx: FlyteContext, variable_name: str) -> typing.Tuple[str, str]:
-        ...
+    def serialize_to_string(self, ctx: FlyteContext, variable_name: str) -> typing.Tuple[str, str]: ...
 
 
 @dataclass

diff --git a/flytekit/core/data_persistence.py b/flytekit/core/data_persistence.py
@@ -17,6 +17,7 @@
    FileAccessProvider
 
 """
+
 import io
 import os
 import pathlib

diff --git a/flytekit/core/dynamic_workflow_task.py b/flytekit/core/dynamic_workflow_task.py
@@ -12,6 +12,7 @@
 dynamic workflows to under fifty tasks. For large-scale identical runs, we recommend the upcoming map task.
 
 """
+
 import functools
 
 from flytekit.core import task

diff --git a/flytekit/core/interface.py b/flytekit/core/interface.py
@@ -109,8 +109,7 @@ def runs_before(self, *args, **kwargs):
                     where runs_before is manually called.
                     """
 
-                def __rshift__(self, *args, **kwargs):
-                    ...  # See runs_before
+                def __rshift__(self, *args, **kwargs): ...  # See runs_before
 
             self._output_tuple_class = Output
         self._docstring = docstring

diff --git a/flytekit/core/legacy_map_task.py b/flytekit/core/legacy_map_task.py
@@ -2,6 +2,7 @@
 Flytekit map tasks specify how to run a single task across a list of inputs. Map tasks themselves are constructed with
 a reference task as well as run-time parameters that limit execution concurrency and failure tolerations.
 """
+
 import functools
 import hashlib
 import logging

diff --git a/flytekit/core/local_fsspec.py b/flytekit/core/local_fsspec.py
@@ -14,6 +14,7 @@
    FlyteLocalFileSystem
 
 """
+
 import os
 
 from fsspec.implementations.local import LocalFileSystem

diff --git a/flytekit/core/notification.py b/flytekit/core/notification.py
@@ -15,6 +15,7 @@
 .. autoclass:: flytekit.core.notification.Notification
 
 """
+
 from typing import List
 
 from flytekit.models import common as _common_model

diff --git a/flytekit/core/promise.py b/flytekit/core/promise.py
@@ -900,28 +900,22 @@ def with_attr(self, key) -> NodeOutput:
 
 class SupportsNodeCreation(Protocol):
     @property
-    def name(self) -> str:
-        ...
+    def name(self) -> str: ...
 
     @property
-    def python_interface(self) -> flyte_interface.Interface:
-        ...
+    def python_interface(self) -> flyte_interface.Interface: ...
 
-    def construct_node_metadata(self) -> _workflow_model.NodeMetadata:
-        ...
+    def construct_node_metadata(self) -> _workflow_model.NodeMetadata: ...
 
 
 class HasFlyteInterface(Protocol):
     @property
-    def name(self) -> str:
-        ...
+    def name(self) -> str: ...
 
     @property
-    def interface(self) -> _interface_models.TypedInterface:
-        ...
+    def interface(self) -> _interface_models.TypedInterface: ...
 
-    def construct_node_metadata(self) -> _workflow_model.NodeMetadata:
-        ...
+    def construct_node_metadata(self) -> _workflow_model.NodeMetadata: ...
 
 
 def extract_obj_name(name: str) -> str:
@@ -1148,11 +1142,9 @@ def create_and_link_node(
 
 
 class LocallyExecutable(Protocol):
-    def local_execute(self, ctx: FlyteContext, **kwargs) -> Union[Tuple[Promise], Promise, VoidPromise, None]:
-        ...
+    def local_execute(self, ctx: FlyteContext, **kwargs) -> Union[Tuple[Promise], Promise, VoidPromise, None]: ...
 
-    def local_execution_mode(self) -> ExecutionState.Mode:
-        ...
+    def local_execution_mode(self) -> ExecutionState.Mode: ...
 
 
 def flyte_entity_call_handler(

diff --git a/flytekit/core/reference_entity.py b/flytekit/core/reference_entity.py
@@ -37,8 +37,7 @@ def id(self) -> _identifier_model.Identifier:
 
     @property
     @abstractmethod
-    def resource_type(self) -> int:
-        ...
+    def resource_type(self) -> int: ...
 
 
 @dataclass

diff --git a/flytekit/core/schedule.py b/flytekit/core/schedule.py
@@ -16,8 +16,7 @@
 
 
 class LaunchPlanTriggerBase(Protocol):
-    def to_flyte_idl(self, *args, **kwargs) -> google_message.Message:
-        ...
+    def to_flyte_idl(self, *args, **kwargs) -> google_message.Message: ...
 
 
 # Duplicates flytekit.common.schedules.Schedule to avoid using the ExtendedSdkType metaclass.

diff --git a/flytekit/core/task.py b/flytekit/core/task.py
@@ -117,8 +117,7 @@ def task(
     pod_template: Optional["PodTemplate"] = ...,
     pod_template_name: Optional[str] = ...,
     accelerator: Optional[BaseAccelerator] = ...,
-) -> Callable[[Callable[..., FuncOut]], PythonFunctionTask[T]]:
-    ...
+) -> Callable[[Callable[..., FuncOut]], PythonFunctionTask[T]]: ...
 
 
 @overload
@@ -155,8 +154,7 @@ def task(
     pod_template: Optional["PodTemplate"] = ...,
     pod_template_name: Optional[str] = ...,
     accelerator: Optional[BaseAccelerator] = ...,
-) -> Union[PythonFunctionTask[T], Callable[..., FuncOut]]:
-    ...
+) -> Union[PythonFunctionTask[T], Callable[..., FuncOut]]: ...
 
 
 def task(

diff --git a/flytekit/core/type_engine.py b/flytekit/core/type_engine.py
@@ -121,8 +121,7 @@ def modify_literal_uris(lit: Literal):
             )
 
 
-class TypeTransformerFailedError(TypeError, AssertionError, ValueError):
-    ...
+class TypeTransformerFailedError(TypeError, AssertionError, ValueError): ...
 
 
 class TypeTransformer(typing.Generic[T]):

diff --git a/flytekit/core/workflow.py b/flytekit/core/workflow.py
@@ -804,8 +804,7 @@ def workflow(
     interruptible: bool = ...,
     on_failure: Optional[Union[WorkflowBase, Task]] = ...,
     docs: Optional[Documentation] = ...,
-) -> Callable[[Callable[..., FuncOut]], PythonFunctionWorkflow]:
-    ...
+) -> Callable[[Callable[..., FuncOut]], PythonFunctionWorkflow]: ...
 
 
 @overload
@@ -815,8 +814,7 @@ def workflow(
     interruptible: bool = ...,
     on_failure: Optional[Union[WorkflowBase, Task]] = ...,
     docs: Optional[Documentation] = ...,
-) -> Union[PythonFunctionWorkflow, Callable[..., FuncOut]]:
-    ...
+) -> Union[PythonFunctionWorkflow, Callable[..., FuncOut]]: ...
 
 
 def workflow(

diff --git a/flytekit/extras/accelerators.py b/flytekit/extras/accelerators.py
@@ -93,6 +93,7 @@ def my_task() -> None:
    A100_80GB
 
 """
+
 import abc
 import copy
 from typing import ClassVar, Generic, Optional, Type, TypeVar
@@ -109,8 +110,7 @@ class BaseAccelerator(abc.ABC, Generic[T]):
     """
 
     @abc.abstractmethod
-    def to_flyte_idl(self) -> T:
-        ...
+    def to_flyte_idl(self) -> T: ...
 
 
 class GPUAccelerator(BaseAccelerator):

diff --git a/flytekit/extras/pytorch/__init__.py b/flytekit/extras/pytorch/__init__.py
@@ -10,6 +10,7 @@
     PyTorchModuleTransformer
     PyTorchTensorTransformer
 """
+
 from flytekit.loggers import logger
 
 # TODO: abstract this out so that there's an established pattern for registering plugins

diff --git a/flytekit/extras/sklearn/__init__.py b/flytekit/extras/sklearn/__init__.py
@@ -7,6 +7,7 @@
 
    SklearnEstimatorTransformer
 """
+
 from flytekit.loggers import logger
 
 # TODO: abstract this out so that there's an established pattern for registering plugins

diff --git a/flytekit/remote/entities.py b/flytekit/remote/entities.py
@@ -2,6 +2,7 @@
 This module contains shadow entities for all Flyte entities as represented in Flyte Admin / Control Plane.
 The goal is to enable easy access, manipulation of these entities.
 """
+
 from __future__ import annotations
 
 from typing import Dict, List, Optional, Tuple, Union

diff --git a/flytekit/remote/executions.py b/flytekit/remote/executions.py
@@ -26,13 +26,11 @@ def inputs(self) -> Optional[LiteralsResolver]:
 
     @property
     @abstractmethod
-    def error(self) -> core_execution_models.ExecutionError:
-        ...
+    def error(self) -> core_execution_models.ExecutionError: ...
 
     @property
     @abstractmethod
-    def is_done(self) -> bool:
-        ...
+    def is_done(self) -> bool: ...
 
     @property
     def outputs(self) -> Optional[LiteralsResolver]:

diff --git a/flytekit/remote/remote.py b/flytekit/remote/remote.py
@@ -3,6 +3,7 @@
 with a Flyte backend in an interactive and programmatic way. This of this experience as kind of like the web UI
 but in Python object form.
 """
+
 from __future__ import annotations
 
 import asyncio

diff --git a/flytekit/remote/remote_callable.py b/flytekit/remote/remote_callable.py
@@ -18,8 +18,7 @@ def __init__(self, *args, **kwargs):
 
     @property
     @abstractmethod
-    def name(self) -> str:
-        ...
+    def name(self) -> str: ...
 
     def construct_node_metadata(self) -> NodeMetadata:
         """

diff --git a/flytekit/types/directory/types.py b/flytekit/types/directory/types.py
@@ -28,8 +28,7 @@
 PathType = typing.Union[str, os.PathLike]
 
 
-def noop():
-    ...
+def noop(): ...
 
 
 @dataclass

diff --git a/flytekit/types/file/file.py b/flytekit/types/file/file.py
@@ -21,8 +21,7 @@
 from flytekit.types.pickle.pickle import FlytePickleTransformer
 
 
-def noop():
-    ...
+def noop(): ...
 
 
 T = typing.TypeVar("T")

diff --git a/flytekit/types/schema/types.py b/flytekit/types/schema/types.py
@@ -68,12 +68,10 @@ def column_names(self) -> typing.Optional[typing.List[str]]:
         return None
 
     @abstractmethod
-    def iter(self, **kwargs) -> typing.Generator[T, None, None]:
-        ...
+    def iter(self, **kwargs) -> typing.Generator[T, None, None]: ...
 
     @abstractmethod
-    def all(self, **kwargs) -> T:
-        ...
+    def all(self, **kwargs) -> T: ...
 
 
 class SchemaWriter(typing.Generic[T]):
@@ -95,8 +93,7 @@ def column_names(self) -> typing.Optional[typing.List[str]]:
         return None
 
     @abstractmethod
-    def write(self, *dfs, **kwargs):
-        ...
+    def write(self, *dfs, **kwargs): ...
 
 
 class LocalIOSchemaReader(SchemaReader[T]):

diff --git a/flytekit/types/structured/__init__.py b/flytekit/types/structured/__init__.py
@@ -12,7 +12,6 @@
    StructuredDatasetDecoder
 """
 
-
 from flytekit.deck.renderer import ArrowRenderer, TopFrameRenderer
 from flytekit.loggers import logger
-Original file line number
+Diff line change
@@ Expand Up / @@ -126,6 +126,7 @@ @@
        ~DataConfig
     """
     from __future__ import annotations
     import base64
@@ Expand Down @@