minor cleanup

Signed-off-by: Felix Ruess <[email protected]>
flyteorg · Mar 1, 2023 · 569b563 · 569b563
1 parent 171ebe8
commit 569b563
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/flytekit/core/container_task.py b/flytekit/core/container_task.py
@@ -61,14 +61,14 @@ def __init__(
             sec_ctx = SecurityContext(secrets=secret_requests)
 
         # pod_template_name overwrites the metadata.pod_template_name
-        kwargs["metadata"] = kwargs["metadata"] if "metadata" in kwargs else TaskMetadata()
-        kwargs["metadata"].pod_template_name = pod_template_name
+        metadata = metadata or TaskMetadata()
+        metadata.pod_template_name = pod_template_name
 
         super().__init__(
             task_type="raw-container",
             name=name,
             interface=Interface(inputs, outputs),
-            # metadata=metadata,
+            metadata=metadata,
             task_config=None,
             security_ctx=sec_ctx,
             **kwargs,

diff --git a/flytekit/core/utils.py b/flytekit/core/utils.py
@@ -173,8 +173,6 @@ def _serialize_pod_spec(pod_template: PodTemplate, primary_container: _task_mode
         final_containers.append(container)
     cast(PodTemplate, pod_template).pod_spec.containers = final_containers
 
-    cast(PodTemplate, pod_template).data_config = primary_container.data_loading_config
-
     return ApiClient().sanitize_for_serialization(cast(PodTemplate, pod_template).pod_spec)