Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Deprecate Log Plugins #94

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Deprecate Log Plugins #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clients/go/coreutils/logs/cloudwatch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func (s cloudwatchLogPlugin) GetTaskLog(podName, namespace, containerName, conta
}, nil
}

// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
func NewCloudwatchLogPlugin(region, groupName string) LogPlugin {
return &cloudwatchLogPlugin{
region: region,
Expand Down
1 change: 1 addition & 0 deletions clients/go/coreutils/logs/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ func (s kubernetesLogPlugin) GetTaskLog(podName, namespace, containerName, conta
}, nil
}

// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
func NewKubernetesLogPlugin(k8sURL string) LogPlugin {
return &kubernetesLogPlugin{
k8sURL: k8sURL,
Expand Down
1 change: 1 addition & 0 deletions clients/go/coreutils/logs/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"github.com/lyft/flyteidl/gen/pb-go/flyteidl/core"
)

// Deprecated: Please use Plugin interface from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
type LogPlugin interface {
// Generates a TaskLog object given necessary computation information
GetTaskLog(podName, namespace, containerName, containerID, logName string) (core.TaskLog, error)
Expand Down
1 change: 1 addition & 0 deletions clients/go/coreutils/logs/stackdriver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ func (s *stackdriverLogPlugin) GetTaskLog(podName, namespace, containerName, con
}, nil
}

// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead.
func NewStackdriverLogPlugin(gcpProject, logResource string) LogPlugin {
return &stackdriverLogPlugin{
gcpProject: gcpProject,
Expand Down