-
Notifications
You must be signed in to change notification settings - Fork 61
Support for containers without Flytekit #62
Conversation
// it is recommended to use the PROTO format. | ||
// JSON and YAML do not need any protobuf definitions to read it | ||
enum MetadataFormat { | ||
JSON = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is JSON the defaultr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because, it is assumed that users of raw container plugin do not have flytekit and hence cannot easily read protobufs
} | ||
// File system path (start at root). This folder will contain all the inputs exploded to a separate file. | ||
// Example, if the input interface needs (x: int, y: blob, z: multipart_blob) and the input path is "/var/flyte/inputs", then the file system will look like | ||
// /var/flyte/inputs/inputs.<metadata format dependent -> .pb .json .yaml> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this file contain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it contains a version of the LiteralMap, but I will clarify in the documentation and update it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
TL;DR
New Plugin for support Flyte CoPilot and arbitrary containers without flytekit
Type
Are all requirements met?
Complete description
Design proposal: https://docs.google.com/document/d/14H5UESK91YN6s1wMGY9EFh-FO8nCOQkJrieK3NQqV08/edit#
Tracking Issue
flyteorg/flyte#297
Follow-up issue
NA