This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Support for containers without Flytekit #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
reviewed
May 12, 2020
| // it is recommended to use the PROTO format. | ||
| // JSON and YAML do not need any protobuf definitions to read it | ||
| enum MetadataFormat { | ||
| JSON = 0; |
There was a problem hiding this comment.
why is JSON the defaultr?
There was a problem hiding this comment.
because, it is assumed that users of raw container plugin do not have flytekit and hence cannot easily read protobufs
katrogan
reviewed
May 12, 2020
| } | ||
| // File system path (start at root). This folder will contain all the inputs exploded to a separate file. | ||
| // Example, if the input interface needs (x: int, y: blob, z: multipart_blob) and the input path is "/var/flyte/inputs", then the file system will look like | ||
| // /var/flyte/inputs/inputs.<metadata format dependent -> .pb .json .yaml> |
There was a problem hiding this comment.
what does this file contain?
There was a problem hiding this comment.
it contains a version of the LiteralMap, but I will clarify in the documentation and update it here
katrogan
previously approved these changes
May 12, 2020
katrogan
approved these changes
May 12, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
New Plugin for support Flyte CoPilot and arbitrary containers without flytekit
Type
Are all requirements met?
Complete description
Design proposal: https://docs.google.com/document/d/14H5UESK91YN6s1wMGY9EFh-FO8nCOQkJrieK3NQqV08/edit#
Tracking Issue
flyteorg/flyte#297
Follow-up issue
NA