Add Presto query message #45
Conversation
| // This message works with the 'presto' task type in the SDK and is the object that will be in the 'custom' field | ||
| // of a Presto task's TaskTemplate | ||
| message PrestoQuery { | ||
| string routing_group = 1; |
There was a problem hiding this comment.
is there a concept of tags like qubole has for hive? are there any other metadata fields that our installation of presto has that would be helpful to include?
There was a problem hiding this comment.
oh but can you bump the setup.py version so that this can be published to pypi?
There was a problem hiding this comment.
@wild-endeavor So there are a couple of ways that you can pass identifying information to Presto, but it's not through tags. First, there is the user which I was planning on deriving from a user's email if they log into Flyte. Then, you can also specify source which in this case will be flyte to indicate where the query is coming from. Here is a screenshot of what these fields look like from the Presto console for a particular query.
So to answer your original question, I think these should be a good set of starting fields. Should we need to add more in the future, I don't think it would be too much work.
Also, what version should I bump setup.py to? Currently it looks like it's set to 0.17.7. Can I just set it to 0.17.8?
* Add Presto query message * add generated protos * update ver
This message is to support functionality for a Presto task