Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Added unmarshal attribute for expires_in for device flow auth token #362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pmahindrakar-oss
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss commented Jan 27, 2023

Signed-off-by: pmahindrakar-oss [email protected]

TL;DR

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

fixes flyteorg/flyte#3288

Follow-up issue

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #362 (db81cf7) into master (c60305c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head db81cf7 differs from pull request most recent head 9d8f4f0. Consider uploading reports for the commit 9d8f4f0 to get more accurate results

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   73.71%   73.74%   +0.03%     
==========================================
  Files          18       18              
  Lines        1377     1379       +2     
==========================================
+ Hits         1015     1017       +2     
  Misses        311      311              
  Partials       51       51              
Flag Coverage Δ
unittests 73.74% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clients/go/admin/deviceflow/token_orchestrator.go 61.46% <100.00%> (+0.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pmahindrakar-oss pmahindrakar-oss marked this pull request as ready for review January 31, 2023 01:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] (Auth) Device flow token expiry not set correctly
1 participant