This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add CheckpointUri to TaskNodeMetadata #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 75.04% 75.04%
=======================================
Files 18 18
Lines 1162 1162
=======================================
Hits 872 872
Misses 237 237
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
force-pushed
the
node-execution-checkpoints
branch
from
d8f4ba3 to
66304f7
Compare
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
force-pushed
the
node-execution-checkpoints
branch
from
e7950e6 to
915cf79
Compare
EngHabu
approved these changes
Sep 20, 2022
hamersaw
approved these changes
Sep 20, 2022
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Add CheckpointUri to TaskNodeMetadata Signed-off-by: Andrew Dye <[email protected]> * Update swagger-codegen-cli image for arm Signed-off-by: Andrew Dye <[email protected]> Signed-off-by: Andrew Dye <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add
CheckpointUritoTaskNodeMetadataso that we can pass intra-task checkpoint path to recovered node executions. This must be stored in admin because propeller does not have direct access to the output path of a prior execution. It will be sent to propeller as part ofNodeExecution.Closure.Additional changes required to propeller and admin
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2254
Follow-up issue
NA