This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Moved the 3legged auth files from flytectl and also added config option for it #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for it Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
8 tasks
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
EngHabu
approved these changes
Apr 28, 2021
EngHabu
pushed a commit
that referenced
this pull request
Apr 29, 2021
…on for it (#156) * Moved the 3legged auth files from flytectl and also added config option for it Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed the expiry bug Signed-off-by: Prafulla Mahindrakar <[email protected]> * Changed logic to refresh the token Signed-off-by: Prafulla Mahindrakar <[email protected]> * Refactored the getAuthenticationDialOption Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
pushed a commit
that referenced
this pull request
Apr 29, 2021
…on for it (#156) * Moved the 3legged auth files from flytectl and also added config option for it Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed the expiry bug Signed-off-by: Prafulla Mahindrakar <[email protected]> * Changed logic to refresh the token Signed-off-by: Prafulla Mahindrakar <[email protected]> * Refactored the getAuthenticationDialOption Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
added a commit
that referenced
this pull request
Apr 30, 2021
…th in admin client (#155) * Introduce Auth Metadata and Identity Grpc Service Signed-off-by: Haytham Abuelfutuh <[email protected]> * merge conflicts Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * cleanup deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * Delete unused catalog client Signed-off-by: Haytham Abuelfutuh <[email protected]> * Remove the need for UseAuth config to simplify setup further Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add deprecated comment Signed-off-by: Haytham Abuelfutuh <[email protected]> * Allow config of insecure creds transmission Signed-off-by: Haytham Abuelfutuh <[email protected]> * Moved the 3legged auth files from flytectl and also added config option for it (#156) * Moved the 3legged auth files from flytectl and also added config option for it Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed the expiry bug Signed-off-by: Prafulla Mahindrakar <[email protected]> * Changed logic to refresh the token Signed-off-by: Prafulla Mahindrakar <[email protected]> * Refactored the getAuthenticationDialOption Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * refactor pkce package Signed-off-by: Haytham Abuelfutuh <[email protected]> * rename Signed-off-by: Haytham Abuelfutuh <[email protected]> * bump for dco Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added ClientSetBuilder inorder to remove keyring dependency (#158) * Added ClientSetBuilder inorder to remove keyring dependency Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added token cache to deprecated method too Signed-off-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Refactoring latest changes Signed-off-by: Haytham Abuelfutuh <[email protected]> * rename Signed-off-by: Haytham Abuelfutuh <[email protected]> * do not close server right away Signed-off-by: Haytham Abuelfutuh <[email protected]> * don't close http server too soon Signed-off-by: Haytham Abuelfutuh <[email protected]> * event init error Signed-off-by: Haytham Abuelfutuh <[email protected]> * Cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * comments Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
…th in admin client (#155) * Introduce Auth Metadata and Identity Grpc Service Signed-off-by: Haytham Abuelfutuh <[email protected]> * merge conflicts Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * cleanup deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * Delete unused catalog client Signed-off-by: Haytham Abuelfutuh <[email protected]> * Remove the need for UseAuth config to simplify setup further Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add deprecated comment Signed-off-by: Haytham Abuelfutuh <[email protected]> * Allow config of insecure creds transmission Signed-off-by: Haytham Abuelfutuh <[email protected]> * Moved the 3legged auth files from flytectl and also added config option for it (#156) * Moved the 3legged auth files from flytectl and also added config option for it Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed the expiry bug Signed-off-by: Prafulla Mahindrakar <[email protected]> * Changed logic to refresh the token Signed-off-by: Prafulla Mahindrakar <[email protected]> * Refactored the getAuthenticationDialOption Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * refactor pkce package Signed-off-by: Haytham Abuelfutuh <[email protected]> * rename Signed-off-by: Haytham Abuelfutuh <[email protected]> * bump for dco Signed-off-by: Haytham Abuelfutuh <[email protected]> * Added ClientSetBuilder inorder to remove keyring dependency (#158) * Added ClientSetBuilder inorder to remove keyring dependency Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added token cache to deprecated method too Signed-off-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * Refactoring latest changes Signed-off-by: Haytham Abuelfutuh <[email protected]> * rename Signed-off-by: Haytham Abuelfutuh <[email protected]> * do not close server right away Signed-off-by: Haytham Abuelfutuh <[email protected]> * don't close http server too soon Signed-off-by: Haytham Abuelfutuh <[email protected]> * event init error Signed-off-by: Haytham Abuelfutuh <[email protected]> * Cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * comments Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: pmahindrakar-oss <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prafulla Mahindrakar [email protected]
TL;DR
Moved the three legged auth to flyteidl and added configuration option for authType
There are two authTypes supported
CLIENTSECRET
THREELEGGEDAUTH
Tested with flytectl conf on demo.nuclyde.io
Config for querying admin
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#945
Follow-up issue
NA