Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Workflow ID comment states that id is autogenerated, that's no longer… #15

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Workflow ID comment states that id is autogenerated, that's no longer… #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions gen/pb-go/flyteidl/core/workflow.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/pb-go/flyteidl/service/admin.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4266,7 +4266,7 @@
"properties": {
"id": {
"$ref": "#/definitions/coreIdentifier",
"description": "This is an autogenerated id by the system. The id is globally unique across the system."
"description": "A globally unique identifier for the workflow."
},
"metadata": {
"$ref": "#/definitions/coreWorkflowMetadata",
Expand Down
3 changes: 1 addition & 2 deletions gen/pb-go/flyteidl/service/flyteadmin/api/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21533,8 +21533,7 @@ definitions:
type: "object"
properties:
id:
description: "This is an autogenerated id by the system. The id is globally\
\ unique across the system."
description: "A globally unique identifier for the workflow."
$ref: "#/definitions/coreIdentifier"
metadata:
description: "Extra metadata about the workflow."
Expand Down
2 changes: 1 addition & 1 deletion gen/pb-go/flyteidl/service/flyteadmin/model_core_workflow_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ package flyteadmin

// Flyte Workflow Structure that encapsulates task, branch and subworkflow nodes to form a statically analyzable, directed acyclic graph.
type CoreWorkflowTemplate struct {
// This is an autogenerated id by the system. The id is globally unique across the system.
// A globally unique identifier for the workflow.
Id *CoreIdentifier `json:"id,omitempty"`
// Extra metadata about the workflow.
Metadata *CoreWorkflowMetadata `json:"metadata,omitempty"`
Expand Down
4 changes: 2 additions & 2 deletions gen/pb-go/flyteidl/service/openapi.go
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions gen/pb-java/flyteidl/core/Workflow.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/pb-protodoc/flyteidl/core/workflow.proto.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ directed acyclic graph.
.. _api_field_flyteidl.core.WorkflowTemplate.id:

id
(:ref:`flyteidl.core.Identifier <api_msg_flyteidl.core.Identifier>`) This is an autogenerated id by the system. The id is globally unique across the system.
(:ref:`flyteidl.core.Identifier <api_msg_flyteidl.core.Identifier>`) A globally unique identifier for the workflow.


.. _api_field_flyteidl.core.WorkflowTemplate.metadata:
Expand Down
4 changes: 2 additions & 2 deletions gen/pb_python/flyteidl/service/flyteadmin/flyteadmin/models/core_workflow_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def __init__(self, id=None, metadata=None, interface=None, nodes=None, outputs=N
def id(self):
"""Gets the id of this CoreWorkflowTemplate. # noqa: E501

This is an autogenerated id by the system. The id is globally unique across the system. # noqa: E501
A globally unique identifier for the workflow. # noqa: E501

:return: The id of this CoreWorkflowTemplate. # noqa: E501
:rtype: CoreIdentifier
Expand All @@ -93,7 +93,7 @@ def id(self):
def id(self, id):
"""Sets the id of this CoreWorkflowTemplate.

This is an autogenerated id by the system. The id is globally unique across the system. # noqa: E501
A globally unique identifier for the workflow. # noqa: E501

:param id: The id of this CoreWorkflowTemplate. # noqa: E501
:type: CoreIdentifier
Expand Down
2 changes: 1 addition & 1 deletion protos/flyteidl/core/workflow.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ message WorkflowMetadata {
// Flyte Workflow Structure that encapsulates task, branch and subworkflow nodes to form a statically analyzable,
// directed acyclic graph.
message WorkflowTemplate {
// This is an autogenerated id by the system. The id is globally unique across the system.
// A globally unique identifier for the workflow.
Identifier id = 1;

// Extra metadata about the workflow.
Expand Down