Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Added workflow for updating flyteidl version in all component #132

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Added workflow for updating flyteidl version in all component #132

merged 3 commits into from
Apr 2, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Mar 30, 2021

TL;DR

  • Added GitHub action cron for updating flyteidl version in all component

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

flyteorg/flyte#868

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@yindia yindia requested a review from EngHabu March 30, 2021 08:27
@yindia
Copy link
Contributor Author

yindia commented Mar 30, 2021

@EngHabu I added cron rather than release event because we create a release in each merge in master and frequent merge in master will create an overlap of PRs. It would be great, If we can run it once/twice a day.

runs-on: ubuntu-latest
strategy:
matrix:
REPOSITORY: [flyteadmin, flytepropeller, flyteconsole, flytekit]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to merge all the other PRs first before this, right?

Copy link
Contributor Author

@yindia yindia Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes...but you can review it

.github/workflows/release-automation.yml Outdated Show resolved Hide resolved
@yindia yindia requested a review from EngHabu April 1, 2021 19:49
@yindia yindia marked this pull request as ready for review April 2, 2021 05:47
@yindia yindia changed the title [WIP] Added workflow for updating flyteidl version in all component Added workflow for updating flyteidl version in all component Apr 2, 2021
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 thank you for doing this

@EngHabu EngHabu merged commit cc492fe into flyteorg:master Apr 2, 2021
samhita-alla added a commit that referenced this pull request Apr 21, 2021
* dark theme updates (#134)

Signed-off-by: cosmicBboy <[email protected]>

* Added workflow for updating flyteidl version in all component (#132)

* Added workflow for updating flyte comopnent version

Signed-off-by: yuvraj <[email protected]>

* Added a single workflow for release flyteidl

Signed-off-by: yuvraj <[email protected]>

* revert workflow changes

Signed-off-by: yuvraj <[email protected]>

* bug fix in ci (#135)

Signed-off-by: yuvraj <[email protected]>

* Enable flyteidl update version for all component (#136)

* enable flyteidl update version for all component

Signed-off-by: yuvraj <[email protected]>

* Added more component

Signed-off-by: yuvraj <[email protected]>

* remove flytekit from component

Signed-off-by: yuvraj <[email protected]>

* Pass dynamic workflow closure in node execution events (#141)

* Documentation for Datacatalog (#143)

Datacatalog service documentation

Signed-off-by: Ketan Umare <[email protected]>

* Fix Datacatalog title.rst in docs (#145)

* missing blank line in title.rst

Signed-off-by: Ketan Umare <[email protected]>

* generated docs

Signed-off-by: Ketan Umare <[email protected]>

* Docs Staging

Signed-off-by: Samhita Alla <[email protected]>

Co-authored-by: Niels Bantilan <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Ketan Umare <[email protected]>
samhita-alla added a commit that referenced this pull request Apr 23, 2021
* dark theme updates (#134)

Signed-off-by: cosmicBboy <[email protected]>

* Added workflow for updating flyteidl version in all component (#132)

* Added workflow for updating flyte comopnent version

Signed-off-by: yuvraj <[email protected]>

* Added a single workflow for release flyteidl

Signed-off-by: yuvraj <[email protected]>

* revert workflow changes

Signed-off-by: yuvraj <[email protected]>

* bug fix in ci (#135)

Signed-off-by: yuvraj <[email protected]>

* Enable flyteidl update version for all component (#136)

* enable flyteidl update version for all component

Signed-off-by: yuvraj <[email protected]>

* Added more component

Signed-off-by: yuvraj <[email protected]>

* remove flytekit from component

Signed-off-by: yuvraj <[email protected]>

* Pass dynamic workflow closure in node execution events (#141)

* Documentation for Datacatalog (#143)

Datacatalog service documentation

Signed-off-by: Ketan Umare <[email protected]>

* Fix Datacatalog title.rst in docs (#145)

* missing blank line in title.rst

Signed-off-by: Ketan Umare <[email protected]>

* generated docs

Signed-off-by: Ketan Umare <[email protected]>

* Docs Staging

Signed-off-by: Samhita Alla <[email protected]>

* Docs Restructure

Signed-off-by: Samhita Alla <[email protected]>

Co-authored-by: Niels Bantilan <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Ketan Umare <[email protected]>
samhita-alla added a commit that referenced this pull request Apr 29, 2021
* dark theme updates (#134)

Signed-off-by: cosmicBboy <[email protected]>

* Added workflow for updating flyteidl version in all component (#132)

* Added workflow for updating flyte comopnent version

Signed-off-by: yuvraj <[email protected]>

* Added a single workflow for release flyteidl

Signed-off-by: yuvraj <[email protected]>

* revert workflow changes

Signed-off-by: yuvraj <[email protected]>

* bug fix in ci (#135)

Signed-off-by: yuvraj <[email protected]>

* Enable flyteidl update version for all component (#136)

* enable flyteidl update version for all component

Signed-off-by: yuvraj <[email protected]>

* Added more component

Signed-off-by: yuvraj <[email protected]>

* remove flytekit from component

Signed-off-by: yuvraj <[email protected]>

* Pass dynamic workflow closure in node execution events (#141)

* Documentation for Datacatalog (#143)

Datacatalog service documentation

Signed-off-by: Ketan Umare <[email protected]>

* Fix Datacatalog title.rst in docs (#145)

* missing blank line in title.rst

Signed-off-by: Ketan Umare <[email protected]>

* generated docs

Signed-off-by: Ketan Umare <[email protected]>

* Docs Staging

Signed-off-by: Samhita Alla <[email protected]>

* Docs Restructure

Signed-off-by: Samhita Alla <[email protected]>

* updated main sidebar

Signed-off-by: Samhita Alla <[email protected]>

Co-authored-by: Niels Bantilan <[email protected]>
Co-authored-by: Yuvraj <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Ketan Umare <[email protected]>
eapolinario pushed a commit that referenced this pull request Sep 8, 2023
* Added workflow for updating flyte comopnent version

Signed-off-by: yuvraj <[email protected]>

* Added a single workflow for release flyteidl

Signed-off-by: yuvraj <[email protected]>

* revert workflow changes

Signed-off-by: yuvraj <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants