This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add Secret Group #114
Merged
Add Secret Group #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
katrogan
reviewed
Mar 13, 2021
| // +required | ||
| string key = 1; | ||
|
|
||
| // The name of the secret group where to find the key referenced above. |
There was a problem hiding this comment.
add required or optional?
katrogan
previously approved these changes
Mar 13, 2021
Signed-off-by: Haytham Abuelfutuh <[email protected]>
|
done thanks for reminding me about bumping the versions... I always forget that |
katrogan
approved these changes
Mar 13, 2021
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Add Secret Group Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Tracking Issue
flyteorg/flyte#800