Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Commit

Permalink
fix comment
Browse files Browse the repository at this point in the history
Signed-off-by: Chao-Han Tsai <[email protected]>
  • Loading branch information
milton0825 committed Apr 19, 2021
1 parent e32bcce commit ab3dc2a
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
12 changes: 6 additions & 6 deletions gen/pb-cpp/flyteidl/datacatalog/datacatalog.grpc.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions gen/pb-go/flyteidl/datacatalog/datacatalog.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/pb_python/flyteidl/datacatalog/datacatalog_pb2_grpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ def GetOrReserveArtifact(self, request, context):
Thus with reservation, only one task can run at a time, until the reservation
expires.
Note: If the task A does not extend the reservation in time and the reservation
expires, another task B may take over the reservation and now we have two tasks
Note: If task A does not extend the reservation in time and the reservation
expires, another task B may take over the reservation, resulting in two tasks
A and B running in parallel. So a third task C may get the Artifact from A or B,
whichever writes last.
"""
Expand Down
4 changes: 2 additions & 2 deletions protos/flyteidl/datacatalog/datacatalog.proto
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ service DataCatalog {
// Thus with reservation, only one task can run at a time, until the reservation
// expires.
//
// Note: If the task A does not extend the reservation in time and the reservation
// expires, another task B may take over the reservation and now we have two tasks
// Note: If task A does not extend the reservation in time and the reservation
// expires, another task B may take over the reservation, resulting in two tasks
// A and B running in parallel. So a third task C may get the Artifact from A or B,
// whichever writes last.
rpc GetOrReserveArtifact (GetOrReserveArtifactRequest) returns (GetOrReserveArtifactResponse);
Expand Down

0 comments on commit ab3dc2a

Please sign in to comment.