Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Commit

Permalink
Workflow ID comment states that id is autogenerated, that's no longer…
Browse files Browse the repository at this point in the history
… true. (#15)
  • Loading branch information
jonathanburns authored Oct 9, 2019
1 parent 040ecf1 commit 756e0b9
Show file tree
Hide file tree
Showing 9 changed files with 37 additions and 38 deletions.
26 changes: 13 additions & 13 deletions gen/pb-go/flyteidl/core/workflow.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/pb-go/flyteidl/service/admin.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -4266,7 +4266,7 @@
"properties": {
"id": {
"$ref": "#/definitions/coreIdentifier",
"description": "This is an autogenerated id by the system. The id is globally unique across the system."
"description": "A globally unique identifier for the workflow."
},
"metadata": {
"$ref": "#/definitions/coreWorkflowMetadata",
Expand Down
3 changes: 1 addition & 2 deletions gen/pb-go/flyteidl/service/flyteadmin/api/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21533,8 +21533,7 @@ definitions:
type: "object"
properties:
id:
description: "This is an autogenerated id by the system. The id is globally\
\ unique across the system."
description: "A globally unique identifier for the workflow."
$ref: "#/definitions/coreIdentifier"
metadata:
description: "Extra metadata about the workflow."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ package flyteadmin

// Flyte Workflow Structure that encapsulates task, branch and subworkflow nodes to form a statically analyzable, directed acyclic graph.
type CoreWorkflowTemplate struct {
// This is an autogenerated id by the system. The id is globally unique across the system.
// A globally unique identifier for the workflow.
Id *CoreIdentifier `json:"id,omitempty"`
// Extra metadata about the workflow.
Metadata *CoreWorkflowMetadata `json:"metadata,omitempty"`
Expand Down
4 changes: 2 additions & 2 deletions gen/pb-go/flyteidl/service/openapi.go

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions gen/pb-java/flyteidl/core/Workflow.java

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/pb-protodoc/flyteidl/core/workflow.proto.rst
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ directed acyclic graph.
.. _api_field_flyteidl.core.WorkflowTemplate.id:

id
(:ref:`flyteidl.core.Identifier <api_msg_flyteidl.core.Identifier>`) This is an autogenerated id by the system. The id is globally unique across the system.
(:ref:`flyteidl.core.Identifier <api_msg_flyteidl.core.Identifier>`) A globally unique identifier for the workflow.


.. _api_field_flyteidl.core.WorkflowTemplate.metadata:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def __init__(self, id=None, metadata=None, interface=None, nodes=None, outputs=N
def id(self):
"""Gets the id of this CoreWorkflowTemplate. # noqa: E501
This is an autogenerated id by the system. The id is globally unique across the system. # noqa: E501
A globally unique identifier for the workflow. # noqa: E501
:return: The id of this CoreWorkflowTemplate. # noqa: E501
:rtype: CoreIdentifier
Expand All @@ -93,7 +93,7 @@ def id(self):
def id(self, id):
"""Sets the id of this CoreWorkflowTemplate.
This is an autogenerated id by the system. The id is globally unique across the system. # noqa: E501
A globally unique identifier for the workflow. # noqa: E501
:param id: The id of this CoreWorkflowTemplate. # noqa: E501
:type: CoreIdentifier
Expand Down
2 changes: 1 addition & 1 deletion protos/flyteidl/core/workflow.proto
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ message WorkflowMetadata {
// Flyte Workflow Structure that encapsulates task, branch and subworkflow nodes to form a statically analyzable,
// directed acyclic graph.
message WorkflowTemplate {
// This is an autogenerated id by the system. The id is globally unique across the system.
// A globally unique identifier for the workflow.
Identifier id = 1;

// Extra metadata about the workflow.
Expand Down

0 comments on commit 756e0b9

Please sign in to comment.