exported literal type for functions

Signed-off-by: Daniel Rammer <[email protected]>
flyteorg · Mar 31, 2023 · 4649cf9 · 4649cf9
1 parent 17062d8
commit 4649cf9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/clients/go/coreutils/typing.go b/clients/go/coreutils/typing.go
@@ -7,7 +7,7 @@ import (
 	"k8s.io/apimachinery/pkg/util/sets"
 )
 
-func literalTypeForPrimitive(primitive *core.Primitive) *core.LiteralType {
+func LiteralTypeForPrimitive(primitive *core.Primitive) *core.LiteralType {
 	simpleType := core.SimpleType_NONE
 	switch primitive.GetValue().(type) {
 	case *core.Primitive_Integer:
@@ -28,12 +28,12 @@ func literalTypeForPrimitive(primitive *core.Primitive) *core.LiteralType {
 }
 
 // Gets literal type for scalar value. This can be used to compare the underlying type of two scalars for compatibility.
-func literalTypeForScalar(scalar *core.Scalar) *core.LiteralType {
+func LiteralTypeForScalar(scalar *core.Scalar) *core.LiteralType {
 	// TODO: Should we just pass the type information with the value?  That way we don't have to guess?
 	var literalType *core.LiteralType
 	switch v := scalar.GetValue().(type) {
 	case *core.Scalar_Primitive:
-		literalType = literalTypeForPrimitive(scalar.GetPrimitive())
+		literalType = LiteralTypeForPrimitive(scalar.GetPrimitive())
 	case *core.Scalar_Blob:
 		if scalar.GetBlob().GetMetadata() == nil {
 			return nil
@@ -88,25 +88,25 @@ func literalTypeForScalar(scalar *core.Scalar) *core.LiteralType {
 func LiteralTypeForLiteral(l *core.Literal) *core.LiteralType {
 	switch l.GetValue().(type) {
 	case *core.Literal_Scalar:
-		return literalTypeForScalar(l.GetScalar())
+		return LiteralTypeForScalar(l.GetScalar())
 	case *core.Literal_Collection:
 		return &core.LiteralType{
 			Type: &core.LiteralType_CollectionType{
-				CollectionType: literalTypeForLiterals(l.GetCollection().Literals),
+				CollectionType: LiteralTypeForLiterals(l.GetCollection().Literals),
 			},
 		}
 	case *core.Literal_Map:
 		return &core.LiteralType{
 			Type: &core.LiteralType_MapValueType{
-				MapValueType: literalTypeForLiterals(maps.Values(l.GetMap().Literals)),
+				MapValueType: LiteralTypeForLiterals(maps.Values(l.GetMap().Literals)),
 			},
 		}
 	}
 
 	return nil
 }
 
-func literalTypeForLiterals(literals []*core.Literal) *core.LiteralType {
+func LiteralTypeForLiterals(literals []*core.Literal) *core.LiteralType {
 	innerType := make([]*core.LiteralType, 0, 1)
 	innerTypeSet := sets.NewString()
 	for _, x := range literals {

diff --git a/clients/go/coreutils/typing_test.go b/clients/go/coreutils/typing_test.go
@@ -9,12 +9,12 @@ import (
 
 func TestLiteralTypeForLiterals(t *testing.T) {
 	t.Run("empty", func(t *testing.T) {
-		lt := literalTypeForLiterals(nil)
+		lt := LiteralTypeForLiterals(nil)
 		assert.Equal(t, core.SimpleType_NONE.String(), lt.GetSimple().String())
 	})
 
 	t.Run("homogenous", func(t *testing.T) {
-		lt := literalTypeForLiterals([]*core.Literal{
+		lt := LiteralTypeForLiterals([]*core.Literal{
 			MustMakeLiteral(5),
 			MustMakeLiteral(0),
 			MustMakeLiteral(5),
@@ -24,7 +24,7 @@ func TestLiteralTypeForLiterals(t *testing.T) {
 	})
 
 	t.Run("non-homogenous", func(t *testing.T) {
-		lt := literalTypeForLiterals([]*core.Literal{
+		lt := LiteralTypeForLiterals([]*core.Literal{
 			MustMakeLiteral("hello"),
 			MustMakeLiteral(5),
 			MustMakeLiteral("world"),
@@ -38,7 +38,7 @@ func TestLiteralTypeForLiterals(t *testing.T) {
 	})
 
 	t.Run("non-homogenous ensure ordering", func(t *testing.T) {
-		lt := literalTypeForLiterals([]*core.Literal{
+		lt := LiteralTypeForLiterals([]*core.Literal{
 			MustMakeLiteral(5),
 			MustMakeLiteral("world"),
 			MustMakeLiteral(0),