Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Updated version of flyteidl (supports enum type) and removed the pinned version #90

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Jun 11, 2021

Signed-off-by: Ketan Umare [email protected]

TL;DR

Flytectl was pinned to an old version of flyteidl. fixed that and updated the version that supports Enum

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

https://docs.google.com/document/d/1rf0hMKbPebJ7jGYpsTDAbJ4ka58KIKD7EgWAEBIH06Q/edit#

Tracking Issue

flyteorg/flyte#590

Follow-up issue

NA

katrogan
katrogan previously approved these changes Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #90 (9eb5d67) into master (f3af555) will increase coverage by 3.29%.
The diff coverage is 68.18%.

❗ Current head 9eb5d67 differs from pull request most recent head 1c3d026. Consider uploading reports for the commit 1c3d026 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   68.15%   71.45%   +3.29%     
==========================================
  Files          93       94       +1     
  Lines        2032     2000      -32     
==========================================
+ Hits         1385     1429      +44     
+ Misses        581      504      -77     
- Partials       66       67       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/create/execution.go 73.91% <ø> (ø)
cmd/get/execution_util.go 55.35% <0.00%> (ø)
pkg/ext/execution_fetcher.go 58.82% <0.00%> (-41.18%) ⬇️
pkg/ext/fetcher.go 100.00% <ø> (ø)
pkg/ext/project_fetcher.go 42.85% <42.85%> (ø)
cmd/get/workflow.go 61.76% <66.66%> (-8.97%) ⬇️
cmd/create/execution_util.go 90.29% <100.00%> (ø)
cmd/get/execution.go 100.00% <100.00%> (+9.09%) ⬆️
cmd/get/launch_plan.go 91.11% <100.00%> (+6.79%) ⬆️
cmd/get/project.go 83.33% <100.00%> (+30.95%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d518435...1c3d026. Read the comment docs.

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
@pmahindrakar-oss pmahindrakar-oss merged commit 089aa7d into master Jun 13, 2021
@pmahindrakar-oss pmahindrakar-oss deleted the enum-support branch June 13, 2021 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants