Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

downgrade python version #87

Merged
merged 1 commit into from
Jun 8, 2021
Merged

downgrade python version #87

merged 1 commit into from
Jun 8, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Jun 8, 2021

TL;DR

Downgrade python version in generate docs workflow
Output : https://github.com/evalsocket/flytectl/runs/2773384675?check_suite_focus=true

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #87 (a838536) into master (f3af555) will increase coverage by 3.29%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   68.15%   71.45%   +3.29%     
==========================================
  Files          93       94       +1     
  Lines        2032     2000      -32     
==========================================
+ Hits         1385     1429      +44     
+ Misses        581      504      -77     
- Partials       66       67       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/create/execution.go 73.91% <ø> (ø)
cmd/get/execution_util.go 55.35% <0.00%> (ø)
pkg/ext/execution_fetcher.go 58.82% <0.00%> (-41.18%) ⬇️
pkg/ext/fetcher.go 100.00% <ø> (ø)
pkg/ext/project_fetcher.go 42.85% <42.85%> (ø)
cmd/get/workflow.go 61.76% <66.66%> (-8.97%) ⬇️
cmd/create/execution_util.go 90.29% <100.00%> (ø)
cmd/get/execution.go 100.00% <100.00%> (+9.09%) ⬆️
cmd/get/launch_plan.go 91.11% <100.00%> (+6.79%) ⬆️
cmd/get/project.go 83.33% <100.00%> (+30.95%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d08e86...a838536. Read the comment docs.

@pmahindrakar-oss pmahindrakar-oss merged commit d518435 into flyteorg:master Jun 8, 2021
@yindia yindia deleted the docs-gen branch June 11, 2021 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants