Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Added boilerplate automation #74

Merged
merged 1 commit into from
May 29, 2021
Merged

Added boilerplate automation #74

merged 1 commit into from
May 29, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented May 27, 2021

TL;DR

  • Added boilerplate automation workflow. It will trigger from the boilerplate repo.
  • Updated boilerplate manually
  • Boilerplate migration from lyft to flyte

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #74 (cf1d56f) into master (e2a8d11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   62.29%   62.29%           
=======================================
  Files          89       89           
  Lines        1867     1867           
=======================================
  Hits         1163     1163           
  Misses        643      643           
  Partials       61       61           
Flag Coverage Δ
unittests 62.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a8d11...cf1d56f. Read the comment docs.

@pmahindrakar-oss
Copy link
Contributor

As per our discussion.
The boiler plate files which are not getting used in the flytectl repo is there a way we can exclude those through the update command or in the repo by adding it to gitignore. eg : docker image build files which are currently not being used in flytectl

@yindia yindia requested a review from pmahindrakar-oss May 29, 2021 08:46
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there an update to .gitignore required ?

@pmahindrakar-oss pmahindrakar-oss merged commit 5cdc946 into flyteorg:master May 29, 2021
@yindia
Copy link
Contributor Author

yindia commented May 29, 2021

@pmahindrakar-oss no

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants