This repository has been archived by the owner on May 31, 2024. It is now read-only.
Update docs for flytectl update project
#458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppiegaze
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
ppiegaze
requested review from
cosmicBboy
and removed request for
EngHabu,
wild-endeavor and
kumare3
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
=======================================
Coverage 67.69% 67.69%
=======================================
Files 148 148
Lines 6639 6639
=======================================
Hits 4494 4494
Misses 1855 1855
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cosmicBboy
previously approved these changes
Jan 30, 2024
cosmicBboy
reviewed
Jan 30, 2024
cosmicBboy
reviewed
Jan 30, 2024
cmd/update/project.go
Outdated
Comment on lines
94
to
96
| * The *state* field only takes effect if the *archive* flag is present in the command. | ||
| * The *activate** flag is not used when updating a project using a *yaml* file. | ||
| Instead, a *state* field value of *0* in conjunction with the *archive* flag is used. |
There was a problem hiding this comment.
the error probably has to do with this bullet list
Signed-off-by: Peeter Piegaze <[email protected]>
ppiegaze
force-pushed
the
docs/peeter/project-archive-with-yaml
branch
from
6af1665
to
291612e
Compare
Signed-off-by: Peeter Piegaze <[email protected]>
ppiegaze
force-pushed
the
docs/peeter/project-archive-with-yaml
branch
from
436aabc
to
1273649
Compare
Signed-off-by: Peeter Piegaze <[email protected]>
ppiegaze
force-pushed
the
docs/peeter/project-archive-with-yaml
branch
from
31e0aad
to
8886a17
Compare
Signed-off-by: Peeter Piegaze <[email protected]>
cosmicBboy
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs for
flytectl update projectto accurately explain archiving and activating using a yaml file