Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Fix struct generation in execution file #434

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

honnix
Copy link
Member

@honnix honnix commented Oct 18, 2023

TL;DR

Fix struct generation in execution file

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Simply encoding the whole struct would result wrong yaml file. AsMap does the proper convertion.

Tracking Issue

Fixes flyteorg/flyte#2682

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (043a611) 67.35% compared to head (1066974) 68.04%.

❗ Current head 1066974 differs from pull request most recent head 2f6e344. Consider uploading reports for the commit 2f6e344 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   67.35%   68.04%   +0.69%     
==========================================
  Files         148      148              
  Lines        6579     5482    -1097     
==========================================
- Hits         4431     3730     -701     
+ Misses       1858     1460     -398     
- Partials      290      292       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/get/execution_util.go 60.22% <40.00%> (+3.62%) ⬆️

... and 135 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@honnix
Copy link
Member Author

honnix commented Oct 19, 2023

@kumare3 Thanks for reviewing. Could you please also help merge it?

@kumare3 kumare3 merged commit cdfa222 into flyteorg:master Oct 19, 2023
12 checks passed
@honnix honnix deleted the fix-struct branch October 19, 2023 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] flytectl get launchplan formats dictionary values incorrectly
2 participants