Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Remove flytekit image priming #412

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Jul 5, 2023

Smoke tested on demo and sandbox.

eapolinario
eapolinario previously approved these changes Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #412 (fe28057) into master (0cb2bfa) will increase coverage by 1.03%.
The diff coverage is 100.00%.

❗ Current head fe28057 differs from pull request most recent head d4e3bdd. Consider uploading reports for the commit d4e3bdd to get more accurate results

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   66.66%   67.70%   +1.03%     
==========================================
  Files         145      145              
  Lines        6285     5223    -1062     
==========================================
- Hits         4190     3536     -654     
+ Misses       1815     1408     -407     
+ Partials      280      279       -1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/sandbox/start.go 61.01% <100.00%> (+7.29%) ⬆️

... and 133 files with indirect coverage changes

@jeevb jeevb force-pushed the jeev/remove-flytekit-pod-priming branch from 3b9931d to b5422eb Compare July 5, 2023 23:04
@jeevb jeevb marked this pull request as ready for review July 5, 2023 23:05
.goreleaser.yml Outdated Show resolved Hide resolved
@jeevb jeevb force-pushed the jeev/remove-flytekit-pod-priming branch from b5422eb to e8e3f77 Compare July 5, 2023 23:18
Signed-off-by: Jeev B <[email protected]>
@jeevb jeevb force-pushed the jeev/remove-flytekit-pod-priming branch from e8e3f77 to d4e3bdd Compare July 5, 2023 23:23
@jeevb jeevb merged commit ac3aa73 into master Jul 5, 2023
@jeevb jeevb deleted the jeev/remove-flytekit-pod-priming branch July 5, 2023 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants