Fix the error message for the update cmd

[oliverhu]

Fix Flyte's #3806 [Housekeeping] Inconsistent treatment of project id param in flytectl

TL;DR

As project name is required rather than project id, check name instead.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Updated behavior

❯ ./bin/flytectl update project -p flytesnack --id flytesnack3
Error: both project and id are passed
❯ ./bin/flytectl update project -p flytesnacks --name flytesnack3
Project flytesnacks updated
❯ ./bin/flytectl update project --id flytesnacks --name flytesnack3
Project flytesnacks updated```

[oliverhu]

@katrogan updated, I think id is not expected to be updated, so added a check for that. Output:

❯ ./bin/flytectl update project -p flytesnack --id flytesnack3
Error: Project `id` can't be updated. Hint: did you mean `-p` instead of `--id` to specify the project?
❯ ./bin/flytectl update project -p flytesnack --name flytesnack3
Project flytesnack failed to update due to rpc error: code = NotFound desc = project [flytesnack] not found
Error: rpc error: code = NotFound desc = project [flytesnack] not found
❯ ./bin/flytectl update project -p flytesnacks --name flytesnack3
Project flytesnacks updated

[katrogan]

I think the issue is we also overwrite the project id to the global project flag: https://github.com/flyteorg/flytectl/blob/master/cmd/config/subcommand/project/project_config.go#L65 passed here: https://github.com/flyteorg/flytectl/blob/master/cmd/update/project.go#L87

Maybe we should only fallback to the global project flag when --id isn't specified

[oliverhu]

Yeah, I saw that. It is very confusing.. what about we change:
func (c *ConfigProject) GetProjectSpec(id string) (*admin.Project, error) { to func (c *ConfigProject) GetProjectSpec() (*admin.Project, error) {

So ProjectSpec will be a 1:1 mapping with the input.

Then we always get Project from config.GetConfig().Project?

[katrogan]

Thank you for this!

[katrogan]

mind fixing up the lint & unit test failures?

[oliverhu]

Updated lint & unit tests, thanks for the patient reviews!

[codecov]

Codecov Report

Merging #411 (ba65726) into master (0cb2bfa) will increase coverage by 0.98%.
The diff coverage is 80.00%.

❗ Current head ba65726 differs from pull request most recent head ebc2caa. Consider uploading reports for the commit ebc2caa to get more accurate results

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   66.66%   67.64%   +0.98%     
==========================================
  Files         145      145              
  Lines        6285     5230    -1055     
==========================================
- Hits         4190     3538     -652     
+ Misses       1815     1411     -404     
- Partials      280      281       +1     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/config/subcommand/project/project_config.go	73.80% <73.68%> (+0.47%)	⬆️
cmd/create/project.go	69.56% <100.00%> (+2.89%)	⬆️
cmd/update/project.go	66.66% <100.00%> (-16.67%)	⬇️
pkg/sandbox/start.go	61.01% <100.00%> (+7.29%)	⬆️

... and 130 files with indirect coverage changes