Add commands to fetch active and archived launchplans #331
Conversation
Issue: flyteorg/flyte#2620 Slack conversation: https://flyte-org.slack.com/archives/CP2HDHKE1/p1655433353538459 Signed-off-by: SmritiSatyanV <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 69.49% 69.49%
=======================================
Files 139 139
Lines 4826 4826
=======================================
Hits 3354 3354
Misses 1230 1230
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -0,0 +1,104 @@ | |||
| .. _flytectl_compile: | |||
There was a problem hiding this comment.
Can you check if this file is added in some index .
cmd/get/launch_plan.go
Outdated
| @@ -55,6 +55,16 @@ Retrieve all the launch plans with filters: | |||
|
|
|||
| flytectl get launchplan -p flytesnacks -d development --filter.fieldSelector="name=core.basic.lp.go_greet" | |||
|
|
|||
| Retrieve all active launch plans with filters: | |||
There was a problem hiding this comment.
nit : you can omit the with filters in both the lines.
We probably want to add all properties which are filterable in the docs not just for launchplan, but for executions, workflows, task , named entity etc and this should be available easily on docs.flyte.org
Can we create a separate ticket to capture this effort
Signed-off-by: SmritiSatyanV <[email protected]>
SmritiSatyanV
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
Signed-off-by: SmritiSatyanV <[email protected]>
Issue: flyteorg/flyte#2620
Slack conversation: https://flyte-org.slack.com/archives/CP2HDHKE1/p1655433353538459
Signed-off-by: SmritiSatyanV [email protected]