Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Rename flytesnacks flag to sourcesPath #116

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Jun 24, 2021

Signed-off-by: Haytham Abuelfutuh [email protected]

TL;DR

Rename flytectl sandbox --flytesnacks=<> to flytectl sandbox --sourcesPath=<> since it can be generalized to any flyte-repo/directory

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Haytham Abuelfutuh <[email protected]>
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #116 (7da2d74) into master (6ef7eb2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files         103      103           
  Lines        2478     2478           
=======================================
  Hits         1821     1821           
  Misses        559      559           
  Partials       98       98           
Impacted Files Coverage Δ
cmd/config/subcommand/sandbox/config_flags.go 15.78% <100.00%> (ø)
cmd/sandbox/start.go 77.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef7eb2...7da2d74. Read the comment docs.

@EngHabu EngHabu merged commit f091117 into master Jun 24, 2021
@EngHabu EngHabu deleted the replace-flytesnacks-flag branch June 24, 2021 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants