This repository has been archived by the owner on May 31, 2024. It is now read-only.
Graphviz interfaces and unit tests #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]> (cherry picked from commit 77be561)
Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
requested review from
EngHabu,
kumare3 and
wild-endeavor
as code owners
pmahindrakar-oss
added a commit
that referenced
this pull request
Jun 18, 2021
* Linter fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added some coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added interface for the mehtods used from graphviz Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed the workflow config flag file and bug fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> (cherry picked from commit 77be561) * Added unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]>
pmahindrakar-oss
added a commit
that referenced
this pull request
Jun 18, 2021
* Linter fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added some coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added interface for the mehtods used from graphviz Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed the workflow config flag file and bug fixes Signed-off-by: Prafulla Mahindrakar <[email protected]> (cherry picked from commit 77be561) * Added unit tests Signed-off-by: Prafulla Mahindrakar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Sample rendered outputs
https://graph.flyte.org/#strict%20digraph%20%20%7B%0A%09n0-%3Eend_node%5B%20%20%5D%3B%0A%09n1-%3Eend_node%5B%20%5D%3B%0A%09n0-%3En1%5B%20%5D%3B%0A%09start_node-%3En0%5B%5D%3B%0A%09start_node-%3En1%5B%5D%3B%0A%09end_node%20%5B%20color%3Dred%2C%20label%3Dend%2C%20shape%3Ddoublecircle%20%5D%3B%0A%09n0%20%5B%20label%3D%22t1%20%5Bpython-task%5D%22%2C%20shape%3Dbox%20%5D%3B%0A%09n1%20%5B%20label%3D%22t2%20%5Bpython-task%5D%22%2C%20shape%3Dbox%20%5D%3B%0A%09start_node%20%5B%20color%3Dgreen%2C%20label%3Dstart%2C%20shape%3Ddoublecircle%20%5D%3B%0A%0A%7D%0A
https://graph.flyte.org/#strict%20digraph%20%20%7B%0A%09n1_n0-%3En1_end_node%5B%20ltail%3D%22cluster_n1%22%20%5D%3B%0A%09n1_n0-%3En1_n1%5B%20lhead%3D%22cluster_n1%22%2C%20ltail%3D%22cluster_n1%22%20%5D%3B%0A%09n1_start_node-%3En1_n0%5B%20lhead%3D%22cluster_n1%22%20%5D%3B%0A%09n1_n1-%3En1_end_node%5B%20ltail%3D%22cluster_n1%22%20%5D%3B%0A%09start_node-%3Enode_t1_parent%3B%0A%09n1_start_node-%3Eend_node%5B%20ltail%3D%22cluster_n1%22%20%5D%3B%0A%09node_t1_parent-%3Eend_node%3B%0A%09node_t1_parent-%3En1_start_node%5B%20lhead%3D%22cluster_n1%22%20%5D%3B%0A%09subgraph%20cluster_n1%20%7B%0A%09n1_end_node%20%5B%20color%3Dred%2C%20label%3Dend%2C%20shape%3Ddoublecircle%20%5D%3B%0A%09n1_n0%20%5B%20label%3D%22t1%20%5Bpython-task%5D%22%2C%20shape%3Dbox%20%5D%3B%0A%09n1_n1%20%5B%20label%3D%22t1%20%5Bpython-task%5D%22%2C%20shape%3Dbox%20%5D%3B%0A%09n1_start_node%20%5B%20color%3Dgreen%2C%20label%3Dstart%2C%20shape%3Ddoublecircle%20%5D%3B%0A%0A%7D%0A%3B%0A%09end_node%20%5B%20color%3Dred%2C%20label%3Dend%2C%20shape%3Ddoublecircle%20%5D%3B%0A%09node_t1_parent%20%5B%20label%3D%22t1%20%5Bpython-task%5D%22%2C%20shape%3Dbox%20%5D%3B%0A%09start_node%20%5B%20color%3Dgreen%2C%20label%3Dstart%2C%20shape%3Ddoublecircle%20%5D%3B%0A%0A%7D%0A
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/