fix: Render timestamp of protobuf in UTC #98
Conversation
|
@BobNisco PTAL, thanks. |
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 67.63% 67.73% +0.10%
==========================================
Files 371 371
Lines 5994 5994
Branches 933 933
==========================================
+ Hits 4054 4060 +6
+ Misses 1940 1934 -6
Continue to review full report at Codecov.
|
| @@ -10,7 +10,7 @@ function primitiveToString(primitive: Primitive): string { | |||
| case 'boolean': | |||
| return !!primitive.boolean ? 'true' : 'false'; | |||
| case 'datetime': | |||
| return formatDate(timestampToDate(primitive.datetime!)); | |||
| return formatDateUTC(timestampToDate(primitive.datetime!)); | |||
There was a problem hiding this comment.
These are the dates that show in the "Inputs/Outputs" tab for a task/execution?
There was a problem hiding this comment.
The Literals components are used anywhere we render a flyte Literal value to the screen. So that would be the inputs/outputs modal for workflow executions, the inputs/outputs tab in the details panel for a task execution, and I think maybe certain cases in the Launch form when rendering a fixed input value that the user cannot change.
|
@honnix Thanks for taking care of this! |
## [0.12.1](http://github.com/lyft/flyteconsole/compare/v0.12.0...v0.12.1) (2020-09-25) ### Bug Fixes * Render timestamp of protobuf in UTC ([#98](http://github.com/lyft/flyteconsole/issues/98)) ([37604a0](http://github.com/lyft/flyteconsole/commit/37604a07f434878cb4177699be27b41923a3af00))
|
🎉 This PR is included in version 0.12.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Render timestamp of protobuf in UTC.
Type
Are all requirements met?
Complete description
When rendering a timestamp field of protobuf, local time instead of UTC is used. This is not consistent with other part of the UI. This PR switches to UTC instead of local timezone.
Tracking Issue
flyteorg/flyte#80
Follow-up issue
NA