Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show full millisecond values for subsecond durations #81

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Jul 6, 2020

flyteorg/flyte#97
For values that are less than 1 second, we can/should show (value)ms instead of just showing <1s. The exact millisecond value is preferable when rendering inputs/outputs.

@schottra schottra changed the base branch from master to next July 6, 2020 23:32
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (next@bed1b81). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next      #81   +/-   ##
=======================================
  Coverage        ?   63.16%           
=======================================
  Files           ?      363           
  Lines           ?     5699           
  Branches        ?      845           
=======================================
  Hits            ?     3600           
  Misses          ?     2099           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed1b81...5d2b8fd. Read the comment docs.

@schottra schottra merged commit 0f7b3c6 into next Jul 6, 2020
@schottra schottra deleted the fix-timedelta-display branch July 6, 2020 23:38
schottra added a commit that referenced this pull request Jul 20, 2020
* fix: show full millisecond values for subsecond durations (#81)

* Bump npm from 6.14.5 to 6.14.6 (#82)

Bumps [npm](https://github.com/npm/cli) from 6.14.5 to 6.14.6.
- [Release notes](https://github.com/npm/cli/releases)
- [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md)
- [Commits](npm/cli@v6.14.5...v6.14.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: show info message for un-launchable workflows (#84)

* refactor: adding utility to help determine if an input type is supported

* fix: adding detection and special rendering for unlaunchable workflows

* fix: implementing error message for unlaunchable workflows

* chore: docs

* chore: pr feedback

* feat: Enables support for Blobs on the Launch form (#86)

* refactor: adds scaffolding for blob input support

* fix: add controls and processing for blob fields

* fix: support using string values for dimensionality in collections

* fix: more info so validators can check subfields

* test: tests for blob input helper

* test: remaining tests for blobs

* chore: cleanup

* refactor: adding some type guards

* test: fixing some test cases

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants