fix: prevents collapsing of execution errors when scrolled out of view #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 63.06% 63.16% +0.10%
==========================================
Files 363 363
Lines 5686 5699 +13
Branches 842 845 +3
==========================================
+ Hits 3586 3600 +14
+ Misses 2100 2099 -1
Continue to review full report at Codecov.
|
podehnal
previously approved these changes
Jul 6, 2020
Co-authored-by: Bob Nisco <[email protected]>
BobNisco
previously approved these changes
Jul 6, 2020
BobNisco
approved these changes
Jul 6, 2020
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jul 6, 2020
## [0.7.3](http://github.com/lyft/flyteconsole/compare/v0.7.2...v0.7.3) (2020-07-06) ### Bug Fixes * prevents collapsing of execution errors when scrolled out of view ([#80](http://github.com/lyft/flyteconsole/issues/80)) ([ba39c1c](http://github.com/lyft/flyteconsole/commit/ba39c1c9c0783d69aee48de2f1b666879472e6b8))
|
🎉 This PR is included in version 0.7.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#64
Since we use virtualization, the components used to render the rows in this table are unmounted every time they leave the viewport. This is great for performance, but it resets state when the component comes back into view. To account for this, we're now storing the expansion state for errors at the table level, and piping them through as an initial state when mounting the components. This will maintain the expansion state when the component leaves and reenters the viewport.
Note: This change should have a corresponding unit test. However, since jsdom does not support layout, we can't test scrolling the component out of the viewport and back in. So it's not possible at the moment to write a unit test for it :-(
Before:
After:
