fix: show dashed lines for empty values instead of removing them #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podehnal
approved these changes
Jul 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 62.99% 63.27% +0.28%
==========================================
Files 363 363
Lines 5685 5686 +1
Branches 840 842 +2
==========================================
+ Hits 3581 3598 +17
+ Misses 2104 2088 -16
Continue to review full report at Codecov.
|
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jul 1, 2020
## [0.7.2](http://github.com/lyft/flyteconsole/compare/v0.7.1...v0.7.2) (2020-07-01) ### Bug Fixes * show dashed lines for empty values instead of removing them ([#79](http://github.com/lyft/flyteconsole/issues/79)) ([0eaaecd](http://github.com/lyft/flyteconsole/commit/0eaaecd2f7c5cf7e2ed33bebaf4f3a4fc57ba697))
|
🎉 This PR is included in version 0.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix to correct a poor experience. My previous implementation of the execution metadata section would completely hide the start time / duration if they didn't have a value. In order to be consistent, I've updated it to show dashes in the case of a missing value, so that the element is always present. I also updated the "Cluster" element to show dashes in the case of a missing value.