Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navlink #772

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: navlink #772

merged 1 commit into from
May 31, 2023

Conversation

4nalog
Copy link
Member

@4nalog 4nalog commented May 31, 2023

Signed-off-by: Soham [email protected]

This PR fixes an issue with a mismatched version in package.json preventing build.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Soham <[email protected]>
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #772 (cccd22b) into master (5e18ed6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   65.84%   65.84%           
=======================================
  Files         491      491           
  Lines       11990    11990           
  Branches     2221     2221           
=======================================
  Hits         7895     7895           
  Misses       4095     4095           
Impacted Files Coverage Δ
...le/src/components/Navigation/NavLinkWithSearch.tsx 0.00% <0.00%> (ø)

@jsonporter jsonporter merged commit 3184646 into master May 31, 2023
@jsonporter jsonporter deleted the fix/navlink branch May 31, 2023 04:16
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants