Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve domain when navigating using sidebar #768

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

4nalog
Copy link
Member

@4nalog 4nalog commented May 25, 2023

TL;DR

fix: preserve project when navigating across tabs using sidebar

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • adds a custom NavLinkWithSearch component to preserve values across navigation

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes flyteorg/flyte#3706

Follow-up issue

NA

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #768 (afc77e8) into master (39c252d) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   65.92%   65.84%   -0.08%     
==========================================
  Files         490      491       +1     
  Lines       11976    11990      +14     
  Branches     2219     2221       +2     
==========================================
  Hits         7895     7895              
- Misses       4081     4095      +14     
Impacted Files Coverage Δ
...le/src/components/Navigation/NavLinkWithSearch.tsx 0.00% <0.00%> (ø)
...le/src/components/Navigation/ProjectNavigation.tsx 0.00% <0.00%> (ø)

@jsonporter jsonporter merged commit 5e18ed6 into master May 26, 2023
@jsonporter jsonporter deleted the issue-#3706 branch May 26, 2023 16:25
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Domain tabs do not persist
3 participants