Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove disable_auth from docs #753

Merged
merged 1 commit into from
May 10, 2023
Merged

chore: remove disable_auth from docs #753

merged 1 commit into from
May 10, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Removes legacy references to DISABLE_AUTH from readme s

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Removes legacy references to DISABLE_AUTH from readme s

Tracking Issue

NA

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and james-union and removed request for a team May 8, 2023 16:26
@ursucarina ursucarina changed the title Carina/chore chore: remove disable_auth from docs May 8, 2023
@ursucarina ursucarina enabled auto-merge (squash) May 8, 2023 16:27
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #753 (96fb19f) into master (29babaa) will increase coverage by 0.16%.
The diff coverage is 60.86%.

❗ Current head 96fb19f differs from pull request most recent head 911c047. Consider uploading reports for the commit 911c047 to get more accurate results

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   65.90%   66.07%   +0.16%     
==========================================
  Files         489      488       -1     
  Lines       11914    11811     -103     
  Branches     2195     2174      -21     
==========================================
- Hits         7852     7804      -48     
+ Misses       4062     4007      -55     
Impacted Files Coverage Δ
...ole/src/components/Workflow/useWorkflowInfoItem.ts 51.16% <0.00%> (ø)
...sole/src/components/Entities/EntityDescription.tsx 79.62% <57.14%> (ø)
...ges/console/src/components/hooks/useDescription.ts 66.66% <75.00%> (ø)
...onsole/src/components/Task/SimpleTaskInterface.tsx 100.00% <100.00%> (ø)
packages/console/src/components/data/apiContext.ts 92.85% <100.00%> (ø)
...ckages/console/src/models/DescriptionEntity/api.ts 87.50% <100.00%> (ø)

... and 9 files with indirect coverage changes

@ursucarina ursucarina merged commit a7d7e1c into master May 10, 2023
@ursucarina ursucarina deleted the carina/chore branch May 10, 2023 22:03
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants