Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: propagate dynamic parent id #751

Merged
merged 6 commits into from
May 5, 2023
Merged

chore: propagate dynamic parent id #751

merged 6 commits into from
May 5, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Attaches a dynamicParentNodeId property to all nodes derived from a dynamic execution

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Attaches a dynamicParentNodeId property to all nodes derived from a dynamic execution

Tracking Issue

NA

Follow-up issue

NA

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and olga-union and removed request for a team May 3, 2023 22:55
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #751 (43fe25c) into master (5b36889) will decrease coverage by 0.57%.
The diff coverage is 75.60%.

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   66.63%   66.06%   -0.57%     
==========================================
  Files         485      485              
  Lines       11773    11764       -9     
  Branches     2162     2164       +2     
==========================================
- Hits         7845     7772      -73     
- Misses       3928     3992      +64     
Impacted Files Coverage Δ
...onsole/src/components/Entities/EntitySchedules.tsx 96.66% <ø> (ø)
.../Executions/ExecutionDetails/ExecutionMetadata.tsx 94.59% <ø> (ø)
...ionDetails/NodeExecutionDetailsContextProvider.tsx 72.22% <ø> (-1.39%) ⬇️
...ackages/console/src/components/Executions/types.ts 100.00% <ø> (ø)
...ackages/console/src/components/Executions/utils.ts 71.17% <ø> (ø)
.../console/src/components/Launch/LaunchForm/utils.ts 64.46% <ø> (ø)
packages/console/src/models/Common/types.ts 100.00% <ø> (ø)
...rc/components/Executions/ExecutionDetails/utils.ts 63.63% <28.57%> (-10.56%) ⬇️
.../src/components/Executions/nodeExecutionQueries.ts 41.05% <63.15%> (-1.96%) ⬇️
...cutionDetails/NodeExecutionDetailsPanelContent.tsx 77.32% <81.57%> (-4.26%) ⬇️
... and 6 more

... and 5 files with indirect coverage changes

Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina enabled auto-merge (squash) May 4, 2023 23:10
@ursucarina ursucarina merged commit e95faa8 into master May 5, 2023
@ursucarina ursucarina deleted the carina/dynparent branch May 5, 2023 01:05
ursucarina added a commit that referenced this pull request May 10, 2023
* chore: propagate dynamic parent id

Signed-off-by: Carina Ursu <[email protected]>

* chore: use app state execution in context panel

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix build err

Signed-off-by: Carina Ursu <[email protected]>

* chore: taskexecutionslist.test.tsx

Signed-off-by: Carina Ursu <[email protected]>

* chore: nodeexecutiondetailspanelcontent.tsx

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

---------

Signed-off-by: Carina Ursu <[email protected]>
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants