Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: guard against /tasks failing #750

Merged
merged 2 commits into from
May 3, 2023
Merged

chore: guard against /tasks failing #750

merged 2 commits into from
May 3, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

guard against /tasks failing

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

NA

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and james-union and removed request for a team May 1, 2023 23:38
Signed-off-by: Carina Ursu <[email protected]>
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #750 (0bbb5c2) into master (8f8d686) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   66.63%   66.53%   -0.11%     
==========================================
  Files         485      485              
  Lines       11770    11773       +3     
  Branches     2162     2162              
==========================================
- Hits         7843     7833      -10     
- Misses       3927     3940      +13     
Impacted Files Coverage Δ
.../src/components/Executions/nodeExecutionQueries.ts 43.01% <50.00%> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

@ursucarina ursucarina enabled auto-merge (squash) May 2, 2023 01:24
@ursucarina ursucarina merged commit 5b36889 into master May 3, 2023
@ursucarina ursucarina deleted the carina/fix2 branch May 3, 2023 15:55
ursucarina added a commit that referenced this pull request May 10, 2023
* chore: guard against /tasks failing

Signed-off-by: Carina Ursu <[email protected]>

* chore: pkg

Signed-off-by: Carina Ursu <[email protected]>

---------

Signed-off-by: Carina Ursu <[email protected]>
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants