Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix crash #746

Merged
merged 1 commit into from
Apr 19, 2023
Merged

chore: fix crash #746

merged 1 commit into from
Apr 19, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Fixes null ref error

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added fallback for when nodes is undefined

Tracking Issue

NA

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and james-union and removed request for a team April 19, 2023 02:28
Signed-off-by: Carina Ursu <[email protected]>
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #746 (86faee4) into master (27238ce) will increase coverage by 0.10%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   66.40%   66.50%   +0.10%     
==========================================
  Files         474      474              
  Lines       11683    11686       +3     
  Branches     2151     2153       +2     
==========================================
+ Hits         7758     7772      +14     
+ Misses       3925     3914      -11     
Impacted Files Coverage Δ
packages/console/src/components/hooks/utils.ts 86.36% <75.00%> (-3.12%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ursucarina ursucarina enabled auto-merge (squash) April 19, 2023 02:46
@ursucarina ursucarina merged commit 7e008cf into master Apr 19, 2023
@ursucarina ursucarina deleted the carina/fix branch April 19, 2023 02:56
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants