[UI Feature] Add full-list log output to execution detail panel #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 66.40% 66.50% +0.10%
==========================================
Files 474 475 +1
Lines 11686 11713 +27
Branches 2153 2155 +2
==========================================
+ Hits 7760 7790 +30
+ Misses 3926 3923 -3
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jsonporter
reviewed
Apr 19, 2023
| return reasons.map( | ||
| reason => | ||
| (reason.occurredAt | ||
| ? formatDateUTC(timestampToDate(reason.occurredAt)) + '\n' |
There was a problem hiding this comment.
We don't want to format the date; just show the text as-is here.
jsonporter
reviewed
Apr 19, 2023
| ) || [] | ||
| ) | ||
| .flat() | ||
| .sort((a, b) => { |
There was a problem hiding this comment.
We also don't want to do sorting here; just print the array as returned.
jsonporter
reviewed
Apr 19, 2023
| taskExecutionDetails?.entities.map( | ||
| taskExecution => taskExecution.closure.reason, | ||
| taskExecution => taskExecution.closure.reasons || [], |
There was a problem hiding this comment.
We need to add a fallback here for cases where users are running older versions of admin; fall back to reason.
Signed-off-by: James <[email protected]>
jsonporter
approved these changes
Apr 19, 2023
ursucarina
pushed a commit
that referenced
this pull request
May 10, 2023
* fix: added scrollable mono text for log messages Signed-off-by: James <[email protected]> * fix: update flyteidl, use reasons instead of reason Signed-off-by: James <[email protected]> * fix: yarn lock file updated * fix: only messages * fix: added fallback for reason Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: Carina Ursu <[email protected]>
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#3592
mono.mov
How to test this:
Even though I had a discussion with Dan, but I could not create a workflow to generate the error messages real time so I just test this with some generated text (increasing by time interval on the video)
This PR includes flyteidl version updates (to v1.3.18).
Type
Are all requirements met?
Complete description
Added a new component ScrollableMonospaceText
Tracking Issue
flyteorg/flyte#3592