fix: passthrough runtime env vars #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursucarina
requested review from
a team,
jsonporter,
4nalog and
olga-union
and removed request for
a team
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
force-pushed
the
carina/customenv
branch
from
a3cc3d4 to
efa0c89
Compare
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 465 465
Lines 11411 11411
Branches 2108 2108
=======================================
Hits 7609 7609
Misses 3802 3802 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yee Hing Tong <[email protected]>
This reverts commit 1bd3ec3. Signed-off-by: Carina Ursu <[email protected]>
wild-endeavor
approved these changes
Apr 12, 2023
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Allows runtime environment variables to be passed through to the UI
Type
Are all requirements met?
Complete description
Adds cheerio and injects window.env into the served html
Tracking Issue
NA
Follow-up issue
NA