feat: show launch plan information in workflow's schedules #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pradithya Aria Pura <[email protected]>
pradithya
requested review from
anrusina and
ursucarina
and removed request for
anrusina
Signed-off-by: Pradithya Aria Pura <[email protected]>
jsonporter
reviewed
Apr 6, 2023
| ); | ||
| })} | ||
| </ul> | ||
| <TableContainer component={Paper}> |
There was a problem hiding this comment.
Let me sync with our UX team on this; we might want to also show which entity version which schedule is applied to.
jsonporter
approved these changes
Apr 7, 2023
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add information of launch plan name and version to the workflow's schedule.
Type
Are all requirements met?
Complete description
When there are multiple scheduled launchplan bound to a workflow, it is hard to understand which schedule correspond to which launchplan. This PR add additional information in the workflow's schedule to include the launch plan name and version. Additionally, when users clicked the launch plan name it will open the launchplan details page.
Before
After
Transition
Screen.Recording.2023-04-01.at.3.32.18.PM.mov
Tracking Issue
fixes flyteorg/flyte#3554
Follow-up issue
NA